All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: netfilter-devel <netfilter-devel@vger.kernel.org>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Subject: NOTRACK removal breaks working configurations
Date: Thu, 20 Dec 2012 11:23:58 +0100	[thread overview]
Message-ID: <20121220102358.GC17461@breakpoint.cc> (raw)

Pablo,

please consider reverting

commit 965505015beccc4ec900798070165875b8e8dccf
Author: Cong Wang <xiyou.wangcong@gmail.com>
Subject: netfilter: remove xt_NOTRACK

It breaks working netfilter configurations.
At the very least, NOTRACK should have printk'd

BIG FAT REMOVAL WARNING

for a year or so.  Which it didn't do.

Now, someone updating from 3.6 to 3.7 will get iptables-restore failure.

             reply	other threads:[~2012-12-20 10:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 10:23 Florian Westphal [this message]
2012-12-20 11:54 ` NOTRACK removal breaks working configurations Pablo Neira Ayuso
2012-12-20 12:28   ` Florian Westphal
2012-12-20 13:02     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121220102358.GC17461@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.