From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: NOTRACK removal breaks working configurations
Date: Thu, 20 Dec 2012 14:02:27 +0100 [thread overview]
Message-ID: <20121220130227.GA4623@1984> (raw)
In-Reply-To: <20121220122839.GD17461@breakpoint.cc>
On Thu, Dec 20, 2012 at 01:28:39PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > commit 965505015beccc4ec900798070165875b8e8dccf
> > > Author: Cong Wang <xiyou.wangcong@gmail.com>
> > > Subject: netfilter: remove xt_NOTRACK
> > >
> > > It breaks working netfilter configurations.
> > > At the very least, NOTRACK should have printk'd
> > >
> > > BIG FAT REMOVAL WARNING
> > >
> > > for a year or so. Which it didn't do.
> >
> > This was announced in Documentation/feature-removal-schedule.txt and
> > the aliasing infrastructure was added to iptables
>
> I know.
>
> > it was agressive since I think not many users have checked that file /
> > they may no have upgrade iptables to latest.
>
> Right.
>
> > Can you see any problem with the patch attached?
>
> No. The patch works.
> [ 21.870092] xt_CT: netfilter: NOTRACK target is deprecated, use CT instead or upgrade iptables
>
> Even better than a revert.
Thanks, I'll pass this to David in the next batch and then ask for
-stable submission.
prev parent reply other threads:[~2012-12-20 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 10:23 NOTRACK removal breaks working configurations Florian Westphal
2012-12-20 11:54 ` Pablo Neira Ayuso
2012-12-20 12:28 ` Florian Westphal
2012-12-20 13:02 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220130227.GA4623@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.