From: Cliff Wickman <cpw@sgi.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ptesarik@suse.cz, kumagai-atsushi@mxc.nes.nec.co.jp,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
vgoyal@redhat.com
Subject: Re: [PATCH] makedumpfile: request the kernel do page scans
Date: Thu, 20 Dec 2012 09:51:47 -0600 [thread overview]
Message-ID: <20121220155147.GA2048@sgi.com> (raw)
In-Reply-To: <20121220.122214.503837449.d.hatayama@jp.fujitsu.com>
On Thu, Dec 20, 2012 at 12:22:14PM +0900, HATAYAMA Daisuke wrote:
> From: Cliff Wickman <cpw@sgi.com>
> Subject: Re: [PATCH] makedumpfile: request the kernel do page scans
> Date: Mon, 10 Dec 2012 09:36:14 -0600
> > On Mon, Dec 10, 2012 at 09:59:29AM +0900, HATAYAMA Daisuke wrote:
> >> From: Cliff Wickman <cpw@sgi.com>
> >> Subject: Re: [PATCH] makedumpfile: request the kernel do page scans
> >> Date: Mon, 19 Nov 2012 12:07:10 -0600
> >>
> >> > On Fri, Nov 16, 2012 at 03:39:44PM -0500, Vivek Goyal wrote:
> >> >> On Thu, Nov 15, 2012 at 04:52:40PM -0600, Cliff Wickman wrote:
> >
> > Hi Hatayama,
> >
> > If ioremap/iounmap is the bottleneck then perhaps you could do what
> > my patch does: it consolidates all the ranges of physical addresses
> > where the boot kernel's page structures reside (see make_kernel_mmap())
> > and passes them to the kernel, which then does a handfull of ioremaps's to
> > cover all of them. Then /proc/vmcore could look up the already-mapped
> > virtual address.
> > (also note a kludge in get_mm_sparsemem() that verifies that each section
> > of the mem_map spans contiguous ranges of page structures. I had
> > trouble with some sections when I made that assumption)
> >
> > I'm attaching 3 patches that might be useful in your testing:
> > - 121210.proc_vmcore2 my current patch that applies to the released
> > makedumpfile 1.5.1
> > - 121207.vmcore_pagescans.sles applies to a 3.0.13 kernel
> > - 121207.vmcore_pagescans.rhel applies to a 2.6.32 kernel
> >
>
> I used the same patch set on the benchmark.
>
> BTW, I have continuously reservation issue, so I think I cannot use
> terabyte memory machine at least in this year.
>
> Also, your patch set is doing ioremap per a chunk of memory map,
> i.e. a number of consequtive pages at the same time. On your terabyte
> machines, how large they are? We have memory consumption issue on the
> 2nd kernel so we must decrease amount of memory used. But looking into
> ioremap code quickly, it looks not using 2MB or 1GB pages to
> remap. This means more than tera bytes page table is generated. Or
> have you probably already investigated this?
>
> BTW, my idea to solve this issue are two:
>
> 1) make linear direct mapping for old memory, and acess the old memory
> via the linear direct mapping, not by ioremap.
>
> - adding remap code in vmcore, or passing the regions that need to
> be remapped using memmap= kernel option to tell the 2nd kenrel to
> map them in addition.
Good point. It would take over 30G of memory to map 16TB with 4k pages.
I recently tried to dump such a memory and ran out of kernel memory --
no wonder!
Do you have a patch for doing a linear direct mapping? Or can you name
existing kernel infrastructure to do such mapping? I'm just looking for
a jumpstart to enhance the patch.
-Cliff
>
> Or,
>
> 2) Support 2MB or 1GB pages in ioremap.
>
> Thanks.
> HATAYAMA, Daisuke
--
Cliff Wickman
SGI
cpw@sgi.com
(651) 683-3824
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Cliff Wickman <cpw@sgi.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: kexec@lists.infradead.org, ptesarik@suse.cz,
linux-kernel@vger.kernel.org, kumagai-atsushi@mxc.nes.nec.co.jp,
vgoyal@redhat.com
Subject: Re: [PATCH] makedumpfile: request the kernel do page scans
Date: Thu, 20 Dec 2012 09:51:47 -0600 [thread overview]
Message-ID: <20121220155147.GA2048@sgi.com> (raw)
In-Reply-To: <20121220.122214.503837449.d.hatayama@jp.fujitsu.com>
On Thu, Dec 20, 2012 at 12:22:14PM +0900, HATAYAMA Daisuke wrote:
> From: Cliff Wickman <cpw@sgi.com>
> Subject: Re: [PATCH] makedumpfile: request the kernel do page scans
> Date: Mon, 10 Dec 2012 09:36:14 -0600
> > On Mon, Dec 10, 2012 at 09:59:29AM +0900, HATAYAMA Daisuke wrote:
> >> From: Cliff Wickman <cpw@sgi.com>
> >> Subject: Re: [PATCH] makedumpfile: request the kernel do page scans
> >> Date: Mon, 19 Nov 2012 12:07:10 -0600
> >>
> >> > On Fri, Nov 16, 2012 at 03:39:44PM -0500, Vivek Goyal wrote:
> >> >> On Thu, Nov 15, 2012 at 04:52:40PM -0600, Cliff Wickman wrote:
> >
> > Hi Hatayama,
> >
> > If ioremap/iounmap is the bottleneck then perhaps you could do what
> > my patch does: it consolidates all the ranges of physical addresses
> > where the boot kernel's page structures reside (see make_kernel_mmap())
> > and passes them to the kernel, which then does a handfull of ioremaps's to
> > cover all of them. Then /proc/vmcore could look up the already-mapped
> > virtual address.
> > (also note a kludge in get_mm_sparsemem() that verifies that each section
> > of the mem_map spans contiguous ranges of page structures. I had
> > trouble with some sections when I made that assumption)
> >
> > I'm attaching 3 patches that might be useful in your testing:
> > - 121210.proc_vmcore2 my current patch that applies to the released
> > makedumpfile 1.5.1
> > - 121207.vmcore_pagescans.sles applies to a 3.0.13 kernel
> > - 121207.vmcore_pagescans.rhel applies to a 2.6.32 kernel
> >
>
> I used the same patch set on the benchmark.
>
> BTW, I have continuously reservation issue, so I think I cannot use
> terabyte memory machine at least in this year.
>
> Also, your patch set is doing ioremap per a chunk of memory map,
> i.e. a number of consequtive pages at the same time. On your terabyte
> machines, how large they are? We have memory consumption issue on the
> 2nd kernel so we must decrease amount of memory used. But looking into
> ioremap code quickly, it looks not using 2MB or 1GB pages to
> remap. This means more than tera bytes page table is generated. Or
> have you probably already investigated this?
>
> BTW, my idea to solve this issue are two:
>
> 1) make linear direct mapping for old memory, and acess the old memory
> via the linear direct mapping, not by ioremap.
>
> - adding remap code in vmcore, or passing the regions that need to
> be remapped using memmap= kernel option to tell the 2nd kenrel to
> map them in addition.
Good point. It would take over 30G of memory to map 16TB with 4k pages.
I recently tried to dump such a memory and ran out of kernel memory --
no wonder!
Do you have a patch for doing a linear direct mapping? Or can you name
existing kernel infrastructure to do such mapping? I'm just looking for
a jumpstart to enhance the patch.
-Cliff
>
> Or,
>
> 2) Support 2MB or 1GB pages in ioremap.
>
> Thanks.
> HATAYAMA, Daisuke
--
Cliff Wickman
SGI
cpw@sgi.com
(651) 683-3824
next prev parent reply other threads:[~2012-12-20 15:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 22:52 [PATCH] makedumpfile: request the kernel do page scans Cliff Wickman
2012-11-16 20:39 ` Vivek Goyal
2012-11-19 18:07 ` Cliff Wickman
2012-12-07 16:50 ` Petr Tesarik
2012-12-10 0:59 ` HATAYAMA Daisuke
2012-12-10 0:59 ` HATAYAMA Daisuke
2012-12-10 15:36 ` Cliff Wickman
2012-12-10 15:36 ` Cliff Wickman
2012-12-20 3:22 ` HATAYAMA Daisuke
2012-12-20 3:22 ` HATAYAMA Daisuke
2012-12-20 15:51 ` Cliff Wickman [this message]
2012-12-20 15:51 ` Cliff Wickman
2012-12-21 1:35 ` HATAYAMA Daisuke
2012-12-21 1:35 ` HATAYAMA Daisuke
2012-12-10 15:43 ` Cliff Wickman
2012-12-10 15:43 ` Cliff Wickman
2012-12-10 15:50 ` Cliff Wickman
2012-12-10 15:50 ` Cliff Wickman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220155147.GA2048@sgi.com \
--to=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ptesarik@suse.cz \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.