From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: Marek Vasut <marex@denx.de>,
alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Tomas Cech <sleep_walker@suse.cz>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: pxa2xx-ac97: fix oops when codec_driver probe runs
Date: Wed, 2 Jan 2013 10:49:39 +0000 [thread overview]
Message-ID: <20130102104939.GA4627@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1356704275-3098-1-git-send-email-mikedunn@newsguy.com>
[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]
On Fri, Dec 28, 2012 at 06:17:55AM -0800, Mike Dunn wrote:
> - /* Punt most of the init to the SoC probe; we may need the machine
> - * driver to do interesting things with the clocking to get us up
> - * and running.
> - */
> - return snd_soc_register_dais(&pdev->dev, pxa_ac97_dai_driver,
> - ARRAY_SIZE(pxa_ac97_dai_driver));
> + ret = snd_soc_register_dais(&pdev->dev, pxa_ac97_dai_driver,
> + ARRAY_SIZE(pxa_ac97_dai_driver));
> + if (ret < 0) {
> + dev_err(&pdev->dev, "snd_soc_register_dais failed with %d\n",
> + ret);
> + return ret;
> + }
> +
> + ret = pxa2xx_ac97_hw_probe(pdev);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "pxa2xx_ac97_hw_probe failed with %d\n",
> + ret);
> + snd_soc_unregister_dais(&pdev->dev,
> + ARRAY_SIZE(pxa_ac97_dai_driver));
> + }
> + return ret;
We should be doing all resource acquisition before registering the DAIs,
if anything this patch introduces the potential for additional issues
with the clocks not having been acquired before we try to use them in
the sound card.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: pxa2xx-ac97: fix oops when codec_driver probe runs
Date: Wed, 2 Jan 2013 10:49:39 +0000 [thread overview]
Message-ID: <20130102104939.GA4627@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1356704275-3098-1-git-send-email-mikedunn@newsguy.com>
On Fri, Dec 28, 2012 at 06:17:55AM -0800, Mike Dunn wrote:
> - /* Punt most of the init to the SoC probe; we may need the machine
> - * driver to do interesting things with the clocking to get us up
> - * and running.
> - */
> - return snd_soc_register_dais(&pdev->dev, pxa_ac97_dai_driver,
> - ARRAY_SIZE(pxa_ac97_dai_driver));
> + ret = snd_soc_register_dais(&pdev->dev, pxa_ac97_dai_driver,
> + ARRAY_SIZE(pxa_ac97_dai_driver));
> + if (ret < 0) {
> + dev_err(&pdev->dev, "snd_soc_register_dais failed with %d\n",
> + ret);
> + return ret;
> + }
> +
> + ret = pxa2xx_ac97_hw_probe(pdev);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "pxa2xx_ac97_hw_probe failed with %d\n",
> + ret);
> + snd_soc_unregister_dais(&pdev->dev,
> + ARRAY_SIZE(pxa_ac97_dai_driver));
> + }
> + return ret;
We should be doing all resource acquisition before registering the DAIs,
if anything this patch introduces the potential for additional issues
with the clocks not having been acquired before we try to use them in
the sound card.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130102/b1c84a0d/attachment-0001.sig>
next prev parent reply other threads:[~2013-01-02 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 14:17 [PATCH] ASoC: pxa2xx-ac97: fix oops when codec_driver probe runs Mike Dunn
2012-12-28 14:17 ` Mike Dunn
2013-01-02 10:49 ` Mark Brown [this message]
2013-01-02 10:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102104939.GA4627@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=mikedunn@newsguy.com \
--cc=sleep_walker@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.