From: Olof Johansson <olof@lixom.net>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, mturquette@linaro.org,
kgene.kim@samsung.com, t.figa@samsung.com,
sylvester.nawrocki@gmail.com
Subject: Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Date: Wed, 2 Jan 2013 11:33:22 -0800 [thread overview]
Message-ID: <20130102193322.GA6583@quad.lixom.net> (raw)
In-Reply-To: <CAJuYYwTbdEDkt41FsJUOt3wq7rq9XHDhMari56GG5T8S1dF7=A@mail.gmail.com>
On Sun, Dec 30, 2012 at 09:35:16PM -0800, Thomas Abraham wrote:
> On 29 December 2012 21:29, Olof Johansson <olof@lixom.net> wrote:
> > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote:
> >> Changes since v4:
> >> - Rebased to linux-3.8-rc1.
> >>
> >> Changes since v3:
> >> - Includes changes suggested by Tomasz Figa <tomasz.figa@gmail.com>
> >>
> >> This patch series migrates the Samsung Exynos4 SoC clock code to adopt the
> >> common clock framework. The use of Samsung specific clock structures has
> >> been removed and all board support code has been updated. imx-style of
> >> clock registration and lookup has been adopted for device tree based
> >> exynos4 platforms.
> >
> > I'd prefer to see if exynos4 and 5 were kept common here, and both transitioned
> > at the same time. Especially since there are no legacy boards for exynos5, it
> > would mean you could have a very clean transition there. What's the plan to
> > follow up with 5?
>
> Ok. I have been looking into Exynos4 since Mr. Kim was already onto
> Exynos5 common clock. Sure, we could do a cleaner Exynos4/5 common
> clock series for v3.9. That would let both exynos4/5 to be built
> together which otherwise this patch series would not allow.
Great, that sounds good. Regressing exynos 4+5 builds would definitely be a bad
thing. In other words, it makes sense to hold off merging the exynos4 pieces
until the 5 counterparts are ready.
> > What are the plans to remove legacy board files on exynos4 at this time
> > and switch them to DT-only? You could do it gradually like Stephen Warren
> > did on Tegra, with hooks that call out to some of the legacy code, but
> > configure the board through device tree and do away with the classic
> > machine descriptors, etc.
>
> I did try this sometime back for exynos4210 based origen board. But
> did not make much progress since certain portions require the older
> samsung gpiolib support and exynos4210 mainline device tree support
> has migrated to newer pinctrl framework. There is some work here to do
> and I will work with Mr. Kim on this.
Great, thanks.
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Date: Wed, 2 Jan 2013 11:33:22 -0800 [thread overview]
Message-ID: <20130102193322.GA6583@quad.lixom.net> (raw)
In-Reply-To: <CAJuYYwTbdEDkt41FsJUOt3wq7rq9XHDhMari56GG5T8S1dF7=A@mail.gmail.com>
On Sun, Dec 30, 2012 at 09:35:16PM -0800, Thomas Abraham wrote:
> On 29 December 2012 21:29, Olof Johansson <olof@lixom.net> wrote:
> > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote:
> >> Changes since v4:
> >> - Rebased to linux-3.8-rc1.
> >>
> >> Changes since v3:
> >> - Includes changes suggested by Tomasz Figa <tomasz.figa@gmail.com>
> >>
> >> This patch series migrates the Samsung Exynos4 SoC clock code to adopt the
> >> common clock framework. The use of Samsung specific clock structures has
> >> been removed and all board support code has been updated. imx-style of
> >> clock registration and lookup has been adopted for device tree based
> >> exynos4 platforms.
> >
> > I'd prefer to see if exynos4 and 5 were kept common here, and both transitioned
> > at the same time. Especially since there are no legacy boards for exynos5, it
> > would mean you could have a very clean transition there. What's the plan to
> > follow up with 5?
>
> Ok. I have been looking into Exynos4 since Mr. Kim was already onto
> Exynos5 common clock. Sure, we could do a cleaner Exynos4/5 common
> clock series for v3.9. That would let both exynos4/5 to be built
> together which otherwise this patch series would not allow.
Great, that sounds good. Regressing exynos 4+5 builds would definitely be a bad
thing. In other words, it makes sense to hold off merging the exynos4 pieces
until the 5 counterparts are ready.
> > What are the plans to remove legacy board files on exynos4 at this time
> > and switch them to DT-only? You could do it gradually like Stephen Warren
> > did on Tegra, with hooks that call out to some of the legacy code, but
> > configure the board through device tree and do away with the classic
> > machine descriptors, etc.
>
> I did try this sometime back for exynos4210 based origen board. But
> did not make much progress since certain portions require the older
> samsung gpiolib support and exynos4210 mainline device tree support
> has migrated to newer pinctrl framework. There is some work here to do
> and I will work with Mr. Kim on this.
Great, thanks.
-Olof
next prev parent reply other threads:[~2013-01-02 19:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 0:33 [PATCH v5 00/12] clk: exynos4: migrate to common clock framework Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 01/12] clk: samsung: add common clock framework helper functions for Samsung platforms Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 02/12] clk: samsung: add pll clock registration helper functions Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 03/12] clk: exynos4: register clocks using common clock framework Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 04/12] ARM: Exynos: Rework timer initialization sequence Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
[not found] ` <1356827621-27617-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-12-30 0:33 ` [PATCH v5 05/12] ARM: Exynos4: Migrate clock support to common clock framework Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 06/12] ARM: dts: add exynos4 clock controller nodes Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 07/12] ARM: dts: add xxti and xusbxti fixed rate clock nodes for exynos4 based platforms Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 08/12] ARM: Exynos4: allow legacy board support to specify xxti and xusbxti clock speed Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 09/12] ARM: dts: add clock provider information for all controllers in Exynos4 SoC Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 10/12] ARM: Exynos4: remove auxdata table from machine file Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 11/12] ARM: Exynos: use fin_pll clock as the tick clock source for mct Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 12/12] ARM: Exynos: add support for mct clock setup Thomas Abraham
2012-12-30 0:33 ` Thomas Abraham
2012-12-30 5:29 ` [PATCH v5 00/12] clk: exynos4: migrate to common clock framework Olof Johansson
2012-12-30 5:29 ` Olof Johansson
2012-12-31 1:37 ` Kukjin Kim
2012-12-31 1:37 ` Kukjin Kim
2013-01-02 19:35 ` Olof Johansson
2013-01-02 19:35 ` Olof Johansson
2012-12-31 5:35 ` Thomas Abraham
2012-12-31 5:35 ` Thomas Abraham
2013-01-02 19:33 ` Olof Johansson [this message]
2013-01-02 19:33 ` Olof Johansson
2013-01-21 14:29 ` Sylwester Nawrocki
2013-01-21 14:29 ` Sylwester Nawrocki
2013-01-21 16:22 ` Tomasz Figa
2013-01-21 16:22 ` Tomasz Figa
2013-01-21 19:07 ` Mike Turquette
2013-01-21 19:07 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102193322.GA6583@quad.lixom.net \
--to=olof@lixom.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.