All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Russell King <linux@arm.linux.org.uk>,
	Eric Biederman <ebiederm@xmission.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] ARM: call disable_nonboot_cpus() from machine_shutdown()
Date: Thu, 3 Jan 2013 12:03:50 +0000	[thread overview]
Message-ID: <20130103120349.GC5193@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1357160861-26282-1-git-send-email-swarren@wwwdotorg.org>

On Wed, Jan 02, 2013 at 09:07:41PM +0000, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> On Tegra at least, this change allows kexec to work with SMP enabled.
> Without this,  machine_shutdown() simply puts all CPUs into a loop. If
> the code of that loop is over-written, the CPUs may hang or crash (which
> I do observe in practice), or cause the kexec'd kernel not to be able to
> initialize them.
> 
> This fix has the added benefit that the kexec always happens on the boot
> CPU, and thus kexec mirrors the initial kernel boot as much as possible.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Acked-by: Will Deacon <will.deacon@arm.com>

Cheers Stephen,

Will

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: call disable_nonboot_cpus() from machine_shutdown()
Date: Thu, 3 Jan 2013 12:03:50 +0000	[thread overview]
Message-ID: <20130103120349.GC5193@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1357160861-26282-1-git-send-email-swarren@wwwdotorg.org>

On Wed, Jan 02, 2013 at 09:07:41PM +0000, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> On Tegra at least, this change allows kexec to work with SMP enabled.
> Without this,  machine_shutdown() simply puts all CPUs into a loop. If
> the code of that loop is over-written, the CPUs may hang or crash (which
> I do observe in practice), or cause the kexec'd kernel not to be able to
> initialize them.
> 
> This fix has the added benefit that the kexec always happens on the boot
> CPU, and thus kexec mirrors the initial kernel boot as much as possible.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Acked-by: Will Deacon <will.deacon@arm.com>

Cheers Stephen,

Will

  parent reply	other threads:[~2013-01-03 12:03 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-02 21:07 [PATCH] ARM: call disable_nonboot_cpus() from machine_shutdown() Stephen Warren
2013-01-02 21:07 ` Stephen Warren
2013-01-02 21:52 ` Russell King - ARM Linux
2013-01-02 21:52   ` Russell King - ARM Linux
2013-01-02 23:59 ` Stephen Boyd
2013-01-02 23:59   ` Stephen Boyd
2013-01-03 12:02   ` Will Deacon
2013-01-03 12:02     ` Will Deacon
2013-01-03 12:21     ` Russell King - ARM Linux
2013-01-03 12:21       ` Russell King - ARM Linux
2013-01-03 18:08       ` Jason Gunthorpe
2013-01-03 18:08         ` Jason Gunthorpe
2013-01-03 20:26       ` Stephen Warren
2013-01-03 20:26         ` Stephen Warren
2013-01-06 16:22         ` Will Deacon
2013-01-06 16:22           ` Will Deacon
2013-01-06 16:40           ` Russell King - ARM Linux
2013-01-06 16:40             ` Russell King - ARM Linux
2013-01-07  1:53             ` Eric W. Biederman
2013-01-07  1:53               ` Eric W. Biederman
2013-01-07 14:25               ` Will Deacon
2013-01-07 14:25                 ` Will Deacon
2013-01-07 14:48               ` Russell King - ARM Linux
2013-01-07 14:48                 ` Russell King - ARM Linux
2013-01-11  5:59                 ` Eric W. Biederman
2013-01-11  5:59                   ` Eric W. Biederman
2013-01-11 10:04                   ` Russell King - ARM Linux
2013-01-11 10:04                     ` Russell King - ARM Linux
2013-01-29 22:01                   ` Stephen Warren
2013-01-29 22:01                     ` Stephen Warren
2013-01-29 22:01                     ` Stephen Warren
2013-01-09  0:06               ` Stephen Warren
2013-01-09  0:06                 ` Stephen Warren
2013-01-11  6:28                 ` Eric W. Biederman
2013-01-11  6:28                   ` Eric W. Biederman
2013-01-29 22:10                   ` Stephen Warren
2013-01-29 22:10                     ` Stephen Warren
2013-01-29 22:10                     ` Stephen Warren
2013-01-03 12:03 ` Will Deacon [this message]
2013-01-03 12:03   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130103120349.GC5193@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.