From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/block/systemace: replaced in16/out16 with more common readw/writew macros
Date: Thu, 03 Jan 2013 13:05:46 +0100 [thread overview]
Message-ID: <20130103120546.3C323200781@gemini.denx.de> (raw)
In-Reply-To: <1357139186-9172-1-git-send-email-alexey.brodkin@gmail.com>
Dear Alexey Brodkin,
In message <1357139186-9172-1-git-send-email-alexey.brodkin@gmail.com> you wrote:
> Most architectures don't have symbols "in16"/"out16" defined.
> Only Microblaze/PowerPC/Spark architectures do have them defined.
>
> At the same time there're much more common macros "readw"/"writew" for
> 16-bit data access defined in most of architectures (in
> linux kernel header "io.h").
>
> So use of "readw"/"writew" makes it possible to build this driver for
> virtually any architecture.
NAK. As expected, this breaks big endian systems like PowerPC.
Tested on AMCC "katmai" board (PPC440SPe):
before (current master):
U-Boot 2013.01-rc2-00174-ge56cdd7 (Jan 03 2013 - 12:41:58)
...
=> fatls ace 0 mnt-xsa
./
../
1250875 kernel.img
19071970 ramdisk.img
2 file(s), 2 dir(s)
After your patch applied:
U-Boot 2013.01-rc2-00174-ge56cdd7-dirty (Jan 03 2013 - 13:01:27)
...
=> fatls ace 0 mnt-xsa
**** ACE CompactFlash not found.
** Bad device size - ace 0 **
So clear NAK.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own. - Don Vonada
next prev parent reply other threads:[~2013-01-03 12:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 15:06 [U-Boot] [PATCH] drivers/block/systemace: replaced in16/out16 with more common readw/writew macros Alexey Brodkin
2013-01-02 15:19 ` Michal Simek
2013-01-02 20:23 ` Wolfgang Denk
2013-01-03 11:35 ` Алексей Бродкин
2013-01-03 12:05 ` Wolfgang Denk [this message]
[not found] ` <CAML3pwX=dfC4vfRfg-Rft5Xuem7q4-7VjtmySvitzWzY3z8JBg@mail.gmail.com>
2013-01-03 12:37 ` Wolfgang Denk
2013-01-04 9:29 ` Алексей Бродкин
2013-01-04 10:22 ` Wolfgang Denk
2013-01-03 13:03 ` Michal Simek
2013-01-03 13:38 ` Wolfgang Denk
2013-01-03 13:53 ` Michal Simek
2013-01-03 14:37 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103120546.3C323200781@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.