From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Vorontsov <anton@enomsg.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/power/88pm860x_battery.c: eliminate possible references to released resources
Date: Mon, 07 Jan 2013 07:09:35 +0000 [thread overview]
Message-ID: <20130107070935.GS7247@mwanda> (raw)
In-Reply-To: <20130107065321.GA31407@lizard.gateway.2wire.net>
On Sun, Jan 06, 2013 at 10:53:21PM -0800, Anton Vorontsov wrote:
> On Mon, Jan 07, 2013 at 09:42:23AM +0300, Dan Carpenter wrote:
> > On Sun, Jan 06, 2013 at 01:16:50PM -0800, Anton Vorontsov wrote:
> > > The patch is whitespace-damaged (for some reason there are two spaces in
> > > the beginning of each non-change line). I repeated changes manually, but
> > > you might want to fix your mail/patch setup anyway. :)
> > >
> >
> > It may be something on your end, the patch applies fine for me.
>
> I just looked into Julia's email headers, and it says:
>
> Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
>
> flowed? for the patch? :) That's not right.
>
> Documentation/email-clients.txt says:
>
> Don't send patches with "format=flowed". This can cause unexpected
> and unwanted line breaks.
>
> :-P
>
> As for why it applied fine for you, your mailer probably automatically
> decodes the content, but I apply mbox file directly. (If I '<ESC>-C' the
> email in mutt, then it also applies for me, but I normally don't do that.)
Ah. You're right, of course. I'm also using mutt but I have
<decode-copy> in my macros like you say.
macro index,pager ap "<shell-escape>rm -f tmp/patch<enter><decode-copy>tmp/patch<enter><shell-escape>~/progs/kernel/apply_patch.sh ~/var/mail/tmp/patch<enter>"
When I pipe to scripts it uses the undecoded copy. I wish I knew
how to use the decoded version there as well...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Vorontsov <anton@enomsg.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/power/88pm860x_battery.c: eliminate possible references to released resources
Date: Mon, 7 Jan 2013 10:09:35 +0300 [thread overview]
Message-ID: <20130107070935.GS7247@mwanda> (raw)
In-Reply-To: <20130107065321.GA31407@lizard.gateway.2wire.net>
On Sun, Jan 06, 2013 at 10:53:21PM -0800, Anton Vorontsov wrote:
> On Mon, Jan 07, 2013 at 09:42:23AM +0300, Dan Carpenter wrote:
> > On Sun, Jan 06, 2013 at 01:16:50PM -0800, Anton Vorontsov wrote:
> > > The patch is whitespace-damaged (for some reason there are two spaces in
> > > the beginning of each non-change line). I repeated changes manually, but
> > > you might want to fix your mail/patch setup anyway. :)
> > >
> >
> > It may be something on your end, the patch applies fine for me.
>
> I just looked into Julia's email headers, and it says:
>
> Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
>
> flowed? for the patch? :) That's not right.
>
> Documentation/email-clients.txt says:
>
> Don't send patches with "format=flowed". This can cause unexpected
> and unwanted line breaks.
>
> :-P
>
> As for why it applied fine for you, your mailer probably automatically
> decodes the content, but I apply mbox file directly. (If I '<ESC>-C' the
> email in mutt, then it also applies for me, but I normally don't do that.)
Ah. You're right, of course. I'm also using mutt but I have
<decode-copy> in my macros like you say.
macro index,pager ap "<shell-escape>rm -f tmp/patch<enter><decode-copy>tmp/patch<enter><shell-escape>~/progs/kernel/apply_patch.sh ~/var/mail/tmp/patch<enter>"
When I pipe to scripts it uses the undecoded copy. I wish I knew
how to use the decoded version there as well...
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-07 7:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 16:16 [PATCH] drivers/power/88pm860x_battery.c: use devm_request_threaded_irq Julia Lawall
2012-12-08 17:16 ` Julia Lawall
2013-01-06 5:09 ` Anton Vorontsov
2013-01-06 5:09 ` Anton Vorontsov
2013-01-06 8:41 ` Julia Lawall
2013-01-06 8:41 ` Julia Lawall
2013-01-06 8:43 ` [PATCH] drivers/power/88pm860x_battery.c: eliminate possible references to released resources Julia Lawall
2013-01-06 8:43 ` Julia Lawall
2013-01-06 21:16 ` Anton Vorontsov
2013-01-06 21:16 ` Anton Vorontsov
2013-01-07 6:42 ` Dan Carpenter
2013-01-07 6:42 ` Dan Carpenter
2013-01-07 6:48 ` Julia Lawall
2013-01-07 6:48 ` Julia Lawall
2013-01-07 6:53 ` Anton Vorontsov
2013-01-07 6:53 ` Anton Vorontsov
2013-01-07 7:09 ` Dan Carpenter [this message]
2013-01-07 7:09 ` Dan Carpenter
2013-01-07 8:00 ` Julia Lawall
2013-01-07 8:00 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107070935.GS7247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.