* [PATCH] use WRITE_FLUSH instead of REQ_FLUSH
@ 2013-01-07 5:12 Mikulas Patocka
2013-01-07 14:23 ` Mike Snitzer
0 siblings, 1 reply; 2+ messages in thread
From: Mikulas Patocka @ 2013-01-07 5:12 UTC (permalink / raw)
To: Alasdair G. Kergon; +Cc: dm-devel, Kasatkin, Dmitry
Hi Alasdair
Please push this patch to 3.8 kernel. (I already sent it before, but it
was forgotten somehow).
Mikulas
---
dm-bufio: use WRITE_FLUSH instead of REQ_FLUSH
Use WRITE_FLUSH instead of REQ_FLUSH to make it consistent with the rest
of the kernel. There is no functional change - the kernel accepts either
WRITE_FLUSH or REQ_FLUSH.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/md/dm-bufio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-3.7-rc6/drivers/md/dm-bufio.c
===================================================================
--- linux-3.7-rc6.orig/drivers/md/dm-bufio.c 2012-11-17 21:14:01.000000000 +0100
+++ linux-3.7-rc6/drivers/md/dm-bufio.c 2012-11-17 21:29:50.000000000 +0100
@@ -1193,7 +1193,7 @@ EXPORT_SYMBOL_GPL(dm_bufio_write_dirty_b
int dm_bufio_issue_flush(struct dm_bufio_client *c)
{
struct dm_io_request io_req = {
- .bi_rw = REQ_FLUSH,
+ .bi_rw = WRITE_FLUSH,
.mem.type = DM_IO_KMEM,
.mem.ptr.addr = NULL,
.client = c->dm_io,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: use WRITE_FLUSH instead of REQ_FLUSH
2013-01-07 5:12 [PATCH] use WRITE_FLUSH instead of REQ_FLUSH Mikulas Patocka
@ 2013-01-07 14:23 ` Mike Snitzer
0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2013-01-07 14:23 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: dm-devel, Kasatkin, Dmitry, Alasdair G. Kergon
On Mon, Jan 07 2013 at 12:12am -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Hi Alasdair
>
> Please push this patch to 3.8 kernel. (I already sent it before, but it
> was forgotten somehow).
>
> Mikulas
>
> ---
>
> dm-bufio: use WRITE_FLUSH instead of REQ_FLUSH
>
> Use WRITE_FLUSH instead of REQ_FLUSH to make it consistent with the rest
> of the kernel. There is no functional change - the kernel accepts either
> WRITE_FLUSH or REQ_FLUSH.
Well the important distinction is the flush bio is originating in
dm-bufio whereas other DM targets that test for REQ_FLUSH are just
passing the flush through. Saying as much makes the need for this patch
more explicit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-07 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-07 5:12 [PATCH] use WRITE_FLUSH instead of REQ_FLUSH Mikulas Patocka
2013-01-07 14:23 ` Mike Snitzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.