From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] ARM: Kirkwood: Fix missing clk for USB device.
Date: Mon, 7 Jan 2013 16:27:39 +0100 [thread overview]
Message-ID: <20130107152739.GA3392@lunn.ch> (raw)
In-Reply-To: <20130107151138.GJ1357@kw.sim.vm.gnt>
On Mon, Jan 07, 2013 at 04:11:38PM +0100, Simon Guinot wrote:
> On Sun, Jan 06, 2013 at 11:10:34AM +0100, Andrew Lunn wrote:
> > Without the clock being held by a driver, it gets turned off at a bad
> > time causing the SoC to lockup. This is often during reboot.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > Tested-by: Stefan Peter <s.peter@mpl.ch>
> > ---
> > arch/arm/boot/dts/kirkwood.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> > index 7735cee..110d6cb 100644
> > --- a/arch/arm/boot/dts/kirkwood.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood.dtsi
> > @@ -144,6 +144,7 @@
> > compatible = "marvell,orion-ehci";
> > reg = <0x50000 0x1000>;
> > interrupts = <19>;
> > + clocks = <&gate_clk 3>;
> > status = "okay";
> > };
>
> Hi Andrew,
>
> Maybe you also want to remove the clock alias workaround from
> kirkwood_legacy_clk_init() ?
Hi Simon
That is not really a fix. It does no harm being there.
We will remove it as a cleanup in 3.9. We can also remove the SDIO
legacy clock as well, since Thomas has patches to convert that driver
to DT.
Andrew
next prev parent reply other threads:[~2013-01-07 15:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 10:10 [PATCH 00/11] Fixes for 3.8-rc Andrew Lunn
2013-01-06 10:10 ` [PATCH 01/11] ARM: Kirkwood: Fix missing clk for USB device Andrew Lunn
2013-01-07 15:11 ` Simon Guinot
2013-01-07 15:27 ` Andrew Lunn [this message]
2013-01-06 10:10 ` [PATCH 02/11] Power: gpio-poweroff: Fix documentation and gpio_is_valid Andrew Lunn
2013-01-06 10:10 ` [PATCH 03/11] ARM: Kirkwood: Switch TWSI1 of 88f6282 to DT clock providers Andrew Lunn
2013-01-06 10:10 ` [PATCH 04/11] ARM: Kirkwood: Fix missing sdio clock Andrew Lunn
2013-01-06 10:10 ` [PATCH 05/11] ARM: Kirkwood: Use fixed-regulator instead of board gpio call Andrew Lunn
2013-01-06 10:10 ` [PATCH 06/11] clk: mvebu: Remove inappropriate __init tagging Andrew Lunn
2013-01-06 10:10 ` [PATCH 07/11] arm: mvebu: Armada XP MV78230 has two cores, not one Andrew Lunn
2013-01-06 10:10 ` [PATCH 08/11] arm: mvebu: Armada XP MV78230 has only three Ethernet interfaces Andrew Lunn
2013-01-06 10:10 ` [PATCH 09/11] arm: mvebu: Add missing ; for cpu node Andrew Lunn
2013-01-06 10:10 ` [PATCH 10/11] dma: mv_xor: fix error handling of mv_xor_channel_add() Andrew Lunn
2013-01-06 10:10 ` [PATCH 11/11] dma: mv_xor: fix error handling for clocks Andrew Lunn
2013-01-07 13:47 ` [PATCH 00/11] Fixes for 3.8-rc Arnd Bergmann
2013-01-07 13:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107152739.GA3392@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.