From: Alberto Garcia <agarcia@igalia.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation
Date: Tue, 8 Jan 2013 17:37:09 +0100 [thread overview]
Message-ID: <20130108163709.GA29828@igalia.com> (raw)
In-Reply-To: <50EC47CB.7070705@suse.de>
On Tue, Jan 08, 2013 at 05:22:35PM +0100, Andreas Färber wrote:
> > Tell me if there's anything else I should change, else I can post
> > the new patches.
>
> Haven't looked at the latest 2/2 patch yet, same might apply there.
> Otherwise no issues spotted in 1/2.
Yes, I updated both patches. Shall I resend them now or wait for more
comments?
> >> Another thing to check (could be a follow-up) is whether the
> >> initfn can be split into instance_init (e.g., pci_set_*?) and
> >> initfn.
There's only PCI code in the init function, does it make sense to
split it? And am I actually supposed to write in the PCI configuration
space from instance_init()?
Berto
next prev parent reply other threads:[~2013-01-08 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 1:10 [Qemu-devel] [PATCH v4 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation Alberto Garcia
2013-01-08 1:10 ` [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 " Alberto Garcia
2013-01-08 13:55 ` Andreas Färber
2013-01-08 15:57 ` Alberto Garcia
2013-01-08 16:22 ` Andreas Färber
2013-01-08 16:37 ` Alberto Garcia [this message]
2013-01-09 0:36 ` Andreas Färber
2013-01-09 1:20 ` Alberto Garcia
2013-01-08 1:10 ` [Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 " Alberto Garcia
2013-01-08 18:08 ` Andreas Färber
2013-01-09 0:56 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108163709.GA29828@igalia.com \
--to=agarcia@igalia.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.