* [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver
@ 2013-01-08 21:37 Simon Guinot
2013-01-09 0:26 ` Jason Cooper
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Simon Guinot @ 2013-01-08 21:37 UTC (permalink / raw)
To: linux-arm-kernel
Note that I am not sure about the MPP value for the PTP functionality.
It seems that the PTP references have been removed from the Marvell
hardware specifications available to me.
Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
---
drivers/pinctrl/mvebu/pinctrl-kirkwood.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
index fa6ce31..02d5b89 100644
--- a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
+++ b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
@@ -66,9 +66,9 @@ static struct mvebu_mpp_mode mv88f6xxx_mpp_modes[] = {
MPP_VAR_FUNCTION(0x5, "sata0", "act", V(0, 1, 1, 1, 1, 0)),
MPP_VAR_FUNCTION(0xb, "lcd", "vsync", V(0, 0, 0, 0, 1, 0))),
MPP_MODE(6,
- MPP_VAR_FUNCTION(0x0, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
- MPP_VAR_FUNCTION(0x1, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
- MPP_VAR_FUNCTION(0x2, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
+ MPP_VAR_FUNCTION(0x1, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
+ MPP_VAR_FUNCTION(0x2, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
+ MPP_VAR_FUNCTION(0x3, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
MPP_MODE(7,
MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(1, 1, 1, 1, 1, 1)),
MPP_VAR_FUNCTION(0x1, "pex", "rsto", V(1, 1, 1, 1, 0, 1)),
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver
2013-01-08 21:37 [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver Simon Guinot
@ 2013-01-09 0:26 ` Jason Cooper
2013-01-09 6:15 ` Andrew Lunn
2013-01-18 19:30 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Jason Cooper @ 2013-01-09 0:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 08, 2013 at 10:37:04PM +0100, Simon Guinot wrote:
> Note that I am not sure about the MPP value for the PTP functionality.
> It seems that the PTP references have been removed from the Marvell
> hardware specifications available to me.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Linus, would you prefer to take this through your tree? I'm fine either
way.
thx,
Jason.
> ---
> drivers/pinctrl/mvebu/pinctrl-kirkwood.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> index fa6ce31..02d5b89 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> @@ -66,9 +66,9 @@ static struct mvebu_mpp_mode mv88f6xxx_mpp_modes[] = {
> MPP_VAR_FUNCTION(0x5, "sata0", "act", V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0xb, "lcd", "vsync", V(0, 0, 0, 0, 1, 0))),
> MPP_MODE(6,
> - MPP_VAR_FUNCTION(0x0, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
> - MPP_VAR_FUNCTION(0x1, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
> - MPP_VAR_FUNCTION(0x2, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
> + MPP_VAR_FUNCTION(0x1, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
> + MPP_VAR_FUNCTION(0x2, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
> + MPP_VAR_FUNCTION(0x3, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
> MPP_MODE(7,
> MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(1, 1, 1, 1, 1, 1)),
> MPP_VAR_FUNCTION(0x1, "pex", "rsto", V(1, 1, 1, 1, 0, 1)),
> --
> 1.7.10
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver
2013-01-08 21:37 [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver Simon Guinot
2013-01-09 0:26 ` Jason Cooper
@ 2013-01-09 6:15 ` Andrew Lunn
2013-01-18 19:30 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2013-01-09 6:15 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 08, 2013 at 10:37:04PM +0100, Simon Guinot wrote:
> Note that I am not sure about the MPP value for the PTP functionality.
> It seems that the PTP references have been removed from the Marvell
> hardware specifications available to me.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> ---
> drivers/pinctrl/mvebu/pinctrl-kirkwood.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> index fa6ce31..02d5b89 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> @@ -66,9 +66,9 @@ static struct mvebu_mpp_mode mv88f6xxx_mpp_modes[] = {
> MPP_VAR_FUNCTION(0x5, "sata0", "act", V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0xb, "lcd", "vsync", V(0, 0, 0, 0, 1, 0))),
> MPP_MODE(6,
> - MPP_VAR_FUNCTION(0x0, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
> - MPP_VAR_FUNCTION(0x1, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
> - MPP_VAR_FUNCTION(0x2, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
> + MPP_VAR_FUNCTION(0x1, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
> + MPP_VAR_FUNCTION(0x2, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
> + MPP_VAR_FUNCTION(0x3, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
> MPP_MODE(7,
> MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(1, 1, 1, 1, 1, 1)),
> MPP_VAR_FUNCTION(0x1, "pex", "rsto", V(1, 1, 1, 1, 0, 1)),
> --
> 1.7.10
Acked-by: Andrew Lunn <andrew@lunn.ch>
I checked against the old MPP.H and the "88F6281 Integrated Controller
Hardware Specifications".
It is interesting that pin 6 cannot be used as a GP[IO] at all. Some
of the other pins are limited to GPO, but this appears to be the only
one which cannot be used at all.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver
2013-01-08 21:37 [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver Simon Guinot
2013-01-09 0:26 ` Jason Cooper
2013-01-09 6:15 ` Andrew Lunn
@ 2013-01-18 19:30 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-01-18 19:30 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 8, 2013 at 10:37 PM, Simon Guinot <simon.guinot@sequanux.org> wrote:
> Note that I am not sure about the MPP value for the PTP functionality.
> It seems that the PTP references have been removed from the Marvell
> hardware specifications available to me.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
Applied with Jason's and Andrew's ACKs!
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-18 19:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 21:37 [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver Simon Guinot
2013-01-09 0:26 ` Jason Cooper
2013-01-09 6:15 ` Andrew Lunn
2013-01-18 19:30 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.