From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger
Date: Wed, 9 Jan 2013 11:56:55 +0000 [thread overview]
Message-ID: <201301091156.55644.arnd@arndb.de> (raw)
In-Reply-To: <20130109111209.GH3931@n2100.arm.linux.org.uk>
On Wednesday 09 January 2013, Russell King - ARM Linux wrote:
> > If so, that's wrong, as it covers many more boards than just Snowball
> > and this is only applicable on the Snowball board. So how else can
> > I enable this feature?
>
> And why is it wrong to enable an optional feature in a defconfig which some
> boards using that defconfig may want?
>
> It's less wrong than forcing user selectable options to be mandatorily
> selected.
Right. The change I suggested fixes the build errors but doesn't actually
make the intended behavior correct. Just using a configuration file is the
right solution here.
It may be a good use case for the "suggest" Kconfig statement I brought
up before: Rather than having snowball hard enable the LEDS subsystem,
it could 'suggest LEDS_CORE' in order to change the default for that
option, but still let users disable it if they want to.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Lee Jones <lee.jones@linaro.org>,
sameo@linux.intel.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com
Subject: Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger
Date: Wed, 9 Jan 2013 11:56:55 +0000 [thread overview]
Message-ID: <201301091156.55644.arnd@arndb.de> (raw)
In-Reply-To: <20130109111209.GH3931@n2100.arm.linux.org.uk>
On Wednesday 09 January 2013, Russell King - ARM Linux wrote:
> > If so, that's wrong, as it covers many more boards than just Snowball
> > and this is only applicable on the Snowball board. So how else can
> > I enable this feature?
>
> And why is it wrong to enable an optional feature in a defconfig which some
> boards using that defconfig may want?
>
> It's less wrong than forcing user selectable options to be mandatorily
> selected.
Right. The change I suggested fixes the build errors but doesn't actually
make the intended behavior correct. Just using a configuration file is the
right solution here.
It may be a good use case for the "suggest" Kconfig statement I brought
up before: Rather than having snowball hard enable the LEDS subsystem,
it could 'suggest LEDS_CORE' in order to change the default for that
option, but still let users disable it if they want to.
Arnd
next prev parent reply other threads:[~2013-01-09 11:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 10:06 [PATCH 1/3] mfd: Fix compile errors and warnings when !CONFIG_AB8500_BM Lee Jones
2013-01-09 10:06 ` Lee Jones
2013-01-09 10:06 ` [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger Lee Jones
2013-01-09 10:06 ` Lee Jones
2013-01-09 10:18 ` Arnd Bergmann
2013-01-09 10:18 ` Arnd Bergmann
2013-01-09 10:35 ` Russell King - ARM Linux
2013-01-09 10:35 ` Russell King - ARM Linux
2013-01-09 11:08 ` Lee Jones
2013-01-09 11:08 ` Lee Jones
2013-01-09 11:12 ` Russell King - ARM Linux
2013-01-09 11:12 ` Russell King - ARM Linux
2013-01-09 11:56 ` Arnd Bergmann [this message]
2013-01-09 11:56 ` Arnd Bergmann
2013-01-09 11:59 ` Russell King - ARM Linux
2013-01-09 11:59 ` Russell King - ARM Linux
2013-01-09 12:02 ` Arnd Bergmann
2013-01-09 12:02 ` Arnd Bergmann
2013-01-09 12:23 ` Lee Jones
2013-01-09 12:23 ` Lee Jones
2013-01-09 12:38 ` Russell King - ARM Linux
2013-01-09 12:38 ` Russell King - ARM Linux
2013-01-09 13:00 ` Lee Jones
2013-01-09 13:00 ` Lee Jones
2013-01-17 10:22 ` Linus Walleij
2013-01-17 10:22 ` Linus Walleij
2013-01-09 10:06 ` [PATCH 3/3] ARM: ux500: Add Snowball pin configuration for user LED Lee Jones
2013-01-09 10:06 ` Lee Jones
2013-01-23 9:36 ` Linus Walleij
2013-01-23 9:36 ` Linus Walleij
2013-02-26 10:32 ` Lee Jones
2013-02-26 10:32 ` Lee Jones
2013-01-22 3:26 ` [PATCH 1/3] mfd: Fix compile errors and warnings when !CONFIG_AB8500_BM Samuel Ortiz
2013-01-22 3:26 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301091156.55644.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.