All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Herz <andi@geekosphere.org>
To: netfilter@vger.kernel.org
Subject: Re: [ANNOUNCE] ipset 6.16.1 released
Date: Wed, 9 Jan 2013 14:48:04 +0100	[thread overview]
Message-ID: <20130109134804.GL31644@workstation> (raw)
In-Reply-To: <alpine.DEB.2.00.1211271510180.15929@blackhole.kfki.hu>

On 27/11/12 at 15:16, Jozsef Kadlecsik wrote:
> I'm happy to announce ipset 6.16.1. The most important part is the patch 
> from Florian Westphal, which fixes netiface set name overflow in the 
> kernel. The RCU handling of the automating increase of the maximal sets 
> feature introduced in 6.15 is also fixed.

It works fine on new machines, but i got this compiler error with some
older system:

In file included from
/usr/src/redhat/BUILD/ipset-6.16.1/kernel/net/netfilter/ipset/ip_set_hash_ip.c:115:

/usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:
In function `hash_ip4_add':

/usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:448:
sorry, unimplemented: inlining failed in call to 'hash_ip4_data_next':
function body not available

/usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:489:
sorry, unimplemented: called from here

make[3]: ***
[/usr/src/redhat/BUILD/ipset-6.16.1/kernel/net/netfilter/ipset/ip_set_hash_ip.o]
Error 1

gcc version 3.4.5 20051201 (Red Hat 3.4.5-2)

Yes it's old and i know gcc update may fix this. But still, is there
another way to fix it? removing the "inline" in front of
type_pf_data_next resolves it somehow as it's compiling through and
seems to work just fine. It "just" results in this warning:

/usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:448:
warning: 'hash_ip4_data_next' declared inline after being called

/usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:448:
warning: previous declaration of 'hash_ip4_data_next' was here

thanks so far.

-- 
Andreas Herz

  reply	other threads:[~2013-01-09 13:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 14:16 [ANNOUNCE] ipset 6.16.1 released Jozsef Kadlecsik
2013-01-09 13:48 ` Andreas Herz [this message]
2013-01-09 22:44   ` Jozsef Kadlecsik
2013-01-09 23:12     ` Jan Engelhardt
2013-01-10  9:06       ` Jozsef Kadlecsik
2013-01-10  9:07       ` Andreas Herz
2013-01-10  9:16         ` Jozsef Kadlecsik
2013-01-10  9:26           ` Andreas Herz
2013-01-10  9:46             ` Jozsef Kadlecsik
2013-01-10  9:55               ` Andreas Herz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130109134804.GL31644@workstation \
    --to=andi@geekosphere.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.