From: Andreas Herz <andi@geekosphere.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Jan Engelhardt <jengelh@inai.de>, netfilter@vger.kernel.org
Subject: Re: [ANNOUNCE] ipset 6.16.1 released
Date: Thu, 10 Jan 2013 10:26:19 +0100 [thread overview]
Message-ID: <20130110092619.GQ31644@workstation> (raw)
In-Reply-To: <alpine.DEB.2.00.1301101008570.11247@blackhole.kfki.hu>
On 10/01/13 at 10:16, Jozsef Kadlecsik wrote:
> On Thu, 10 Jan 2013, Andreas Herz wrote:
>
> > On 10/01/13 at 00:12, Jan Engelhardt wrote:
> > >
> > > On Wednesday 2013-01-09 23:44, Jozsef Kadlecsik wrote:
> > > >- KCFLAGS="-DPACKAGE_VERSION=$(PACKAGE_VERSION)" \
> > > >+ KCFLAGS="-DPACKAGE_VERSION=$(PACKAGE_VERSION)-DINLINE=$(INLINE)" \
> > >
> > > You seem to be missing a space before -DINL
> >
> > I also changed this in the patch, but still:
> >
> > /usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:
> > In function `hash_ip4_add':
> > /usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:444:
> > sorry, unimplemented: inlining failed in call to 'hash_ip4_data_next':
> > function body not available
> > /usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:485:
> > sorry, unimplemented: called from here
>
> So in the generated config.h you can find the next, right?
>
> /* Inline in prototype supported. */
> #define INLINE_IN_PROTOTYPE 1
>
Yes this part is in the config.h
> > Don't bother too much, as i can build it on another machine, but i'm
> > curious why it won't work and how it should be fixed.
>
> The old gcc does not accept the "inline" keyword in the function
> prototype. The patch attempted to detect it and depending on the result,
> the keyword is used or not.
Thanks for the explanation.
--
Andreas Herz
next prev parent reply other threads:[~2013-01-10 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 14:16 [ANNOUNCE] ipset 6.16.1 released Jozsef Kadlecsik
2013-01-09 13:48 ` Andreas Herz
2013-01-09 22:44 ` Jozsef Kadlecsik
2013-01-09 23:12 ` Jan Engelhardt
2013-01-10 9:06 ` Jozsef Kadlecsik
2013-01-10 9:07 ` Andreas Herz
2013-01-10 9:16 ` Jozsef Kadlecsik
2013-01-10 9:26 ` Andreas Herz [this message]
2013-01-10 9:46 ` Jozsef Kadlecsik
2013-01-10 9:55 ` Andreas Herz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110092619.GQ31644@workstation \
--to=andi@geekosphere.org \
--cc=jengelh@inai.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.