From: Stephen Hemminger <shemminger@vyatta.com>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: mst@redhat.com, netdev@vger.kernel.org, stephen@redhat.com,
bridge@lists.linux-foundation.org, shmulik.ladkani@gmail.com,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v5 02/14] bridge: Add vlan filtering infrastructure
Date: Thu, 10 Jan 2013 10:36:14 -0800 [thread overview]
Message-ID: <20130110103614.23383079@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1357751882-8619-3-git-send-email-vyasevic@redhat.com>
This patch has some minor whitespace and spelling errors:
WARNING: line over 80 characters
#429: FILE: net/bridge/br_private.h:205:
+static inline struct net_bridge_port *vlans_to_port(struct net_port_vlans *vlans)
ERROR: trailing whitespace
#432: FILE: net/bridge/br_private.h:208:
+ $
WARNING: please, no spaces at the start of a line
#432: FILE: net/bridge/br_private.h:208:
+ $
+/* Must be protected by RTNL */
+static void br_vlan_del(struct net_bridge_vlan *vlan)
+ /* Drop the self-ref to trigger descrution. */
^^^^^^^^^^
Also, the data structure vlan's seems inverted. Why do you keep a hash list
of vlan's and then a bitmap of ports. Seems more natural to just put a bitmap
on each port that has vlan filtering rather than introducing yet another list
to manage.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: mst@redhat.com, netdev@vger.kernel.org, stephen@redhat.com,
bridge@lists.linux-foundation.org, shmulik.ladkani@gmail.com,
davem@davemloft.net
Subject: Re: [PATCH net-next v5 02/14] bridge: Add vlan filtering infrastructure
Date: Thu, 10 Jan 2013 10:36:14 -0800 [thread overview]
Message-ID: <20130110103614.23383079@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1357751882-8619-3-git-send-email-vyasevic@redhat.com>
This patch has some minor whitespace and spelling errors:
WARNING: line over 80 characters
#429: FILE: net/bridge/br_private.h:205:
+static inline struct net_bridge_port *vlans_to_port(struct net_port_vlans *vlans)
ERROR: trailing whitespace
#432: FILE: net/bridge/br_private.h:208:
+ $
WARNING: please, no spaces at the start of a line
#432: FILE: net/bridge/br_private.h:208:
+ $
+/* Must be protected by RTNL */
+static void br_vlan_del(struct net_bridge_vlan *vlan)
+ /* Drop the self-ref to trigger descrution. */
^^^^^^^^^^
Also, the data structure vlan's seems inverted. Why do you keep a hash list
of vlan's and then a bitmap of ports. Seems more natural to just put a bitmap
on each port that has vlan filtering rather than introducing yet another list
to manage.
next prev parent reply other threads:[~2013-01-10 18:36 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 17:17 [PATCH net-next V5 00/14] Add basic VLAN support to bridges Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 01/14] vlan: wrap hw-acceleration calls in separate functions Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-10 18:25 ` Stephen Hemminger
2013-01-10 18:25 ` Stephen Hemminger
2013-01-10 18:41 ` Vlad Yasevich
2013-01-10 18:42 ` [Bridge] " Vlad Yasevich
2013-01-10 22:07 ` Stephen Hemminger
2013-01-10 22:07 ` Stephen Hemminger
2013-01-11 1:08 ` Vlad Yasevich
2013-01-11 1:08 ` [Bridge] " Vlad Yasevich
2013-01-11 17:20 ` Stephen Hemminger
2013-01-11 17:20 ` Stephen Hemminger
2013-01-11 17:41 ` Vlad Yasevich
2013-01-11 17:41 ` [Bridge] " Vlad Yasevich
2013-01-11 18:23 ` Stephen Hemminger
2013-01-11 18:23 ` Stephen Hemminger
2013-01-11 18:53 ` Vlad Yasevich
2013-01-11 18:53 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 02/14] bridge: Add vlan filtering infrastructure Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-10 18:36 ` Stephen Hemminger [this message]
2013-01-10 18:36 ` Stephen Hemminger
2013-01-10 19:01 ` Vlad Yasevich
2013-01-10 19:01 ` [Bridge] " Vlad Yasevich
2013-01-10 19:23 ` Vlad Yasevich
2013-01-10 19:23 ` [Bridge] " Vlad Yasevich
2013-01-10 22:10 ` Stephen Hemminger
2013-01-10 22:10 ` Stephen Hemminger
2013-01-11 1:14 ` Vlad Yasevich
2013-01-11 1:14 ` [Bridge] " Vlad Yasevich
2013-01-11 13:53 ` Shmulik Ladkani
2013-01-11 13:54 ` [Bridge] " Shmulik Ladkani
2013-01-11 15:33 ` Vlad Yasevich
2013-01-11 15:33 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 03/14] bridge: Validate that vlan is permitted on ingress Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 04/14] bridge: Verify that a vlan is allowed to egress on give port Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 05/14] bridge: Cache vlan in the cb for faster egress lookup Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 06/14] bridge: Add vlan to unicast fdb entries Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 07/14] bridge: Add vlan id to multicast groups Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 08/14] bridge: Add netlink interface to configure vlans on bridge ports Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 09/14] bridge: Add vlan support to static neighbors Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 10/14] bridge: Add the ability to configure pvid Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH 10/14] bridge: Add the ability to pvid Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:24 ` Vlad Yasevich
2013-01-09 17:24 ` [Bridge] " Vlad Yasevich
2013-01-09 17:17 ` [PATCH net-next v5 11/14] bridge: API to configure egress policy Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:18 ` [PATCH net-next v5 12/14] bridge: Implement vlan ingress/egress policy Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:18 ` [PATCH net-next v5 13/14] bridge: Dump vlan information from a bridge port Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
2013-01-09 17:18 ` [PATCH net-next v5 14/14] bridge: Add vlan support for local fdb entries Vlad Yasevich
2013-01-09 17:18 ` [Bridge] " Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110103614.23383079@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=stephen@redhat.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.