From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: Fix phy_init for Marvell network eth driver
Date: Thu, 10 Jan 2013 13:24:41 +0100 [thread overview]
Message-ID: <20130110122441.GQ3392@lunn.ch> (raw)
In-Reply-To: <1357819234-27752-1-git-send-email-konszert@marvell.com>
On Thu, Jan 10, 2013 at 02:00:32PM +0200, Kosta Zertsekel wrote:
> Hi all,
> resubmitting the patch for Marvell mv643xx driver (patch 1/2) adding the below explanation (thanks to Florian F.):
> The D-Link DNS323_REV_C1 board has a specific PHY device fixup using the flag MARVELL_PHY_M1118_DNS323_LEDS which is set by the architecture code in arch/arm/mach-orion5x/dns323-setup.c. This flag is unfortunately lost during the call to phy_attach() in mv643xx_eth and therefore, the underlying Marvell PHY driver cannot make use of this flag to fixup the PHY device LEDs. This patch ensures the phy->dev_flags value is passed to the phy_attach() function such that the PHY device driver can
> actually use it.
>
> Also submitting new patch 2/2 using the same (or at least very close in meaning) explanation.
>
Hi Kosta
This comment is supposed to be in the header of the patch.
Since this comment is about a bug for the D-Link DNS323_REV_C1, the
fix to DSA should be in a separate patch, again with a comment about
the patch, why its needed, what if fixes etc.
I suggest you take a look at Documentation/SubmittingPatches
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Kosta Zertsekel <konszert@marvell.com>
Cc: netdev@vger.kernel.org, zertsekel@gmail.com, andrew@lunn.ch,
benavi@marvell.com, linux-arm-kernel@lists.infradead.org,
alior@marvell.com
Subject: Re: Fix phy_init for Marvell network eth driver
Date: Thu, 10 Jan 2013 13:24:41 +0100 [thread overview]
Message-ID: <20130110122441.GQ3392@lunn.ch> (raw)
In-Reply-To: <1357819234-27752-1-git-send-email-konszert@marvell.com>
On Thu, Jan 10, 2013 at 02:00:32PM +0200, Kosta Zertsekel wrote:
> Hi all,
> resubmitting the patch for Marvell mv643xx driver (patch 1/2) adding the below explanation (thanks to Florian F.):
> The D-Link DNS323_REV_C1 board has a specific PHY device fixup using the flag MARVELL_PHY_M1118_DNS323_LEDS which is set by the architecture code in arch/arm/mach-orion5x/dns323-setup.c. This flag is unfortunately lost during the call to phy_attach() in mv643xx_eth and therefore, the underlying Marvell PHY driver cannot make use of this flag to fixup the PHY device LEDs. This patch ensures the phy->dev_flags value is passed to the phy_attach() function such that the PHY device driver can
> actually use it.
>
> Also submitting new patch 2/2 using the same (or at least very close in meaning) explanation.
>
Hi Kosta
This comment is supposed to be in the header of the patch.
Since this comment is about a bug for the D-Link DNS323_REV_C1, the
fix to DSA should be in a separate patch, again with a comment about
the patch, why its needed, what if fixes etc.
I suggest you take a look at Documentation/SubmittingPatches
Thanks
Andrew
next prev parent reply other threads:[~2013-01-10 12:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 12:00 Fix phy_init for Marvell network eth driver Kosta Zertsekel
2013-01-10 12:00 ` Kosta Zertsekel
2013-01-10 12:00 ` [PATCH 1/2] " Kosta Zertsekel
2013-01-10 12:00 ` Kosta Zertsekel
2013-01-10 13:22 ` Sergei Shtylyov
2013-01-10 13:22 ` Sergei Shtylyov
2013-01-10 12:00 ` [PATCH 2/2] Fix phy_attach - forward dev_flags for phy_attach Kosta Zertsekel
2013-01-10 12:00 ` Kosta Zertsekel
2013-01-10 14:40 ` Florian Fainelli
2013-01-10 14:40 ` Florian Fainelli
2013-01-10 15:57 ` Kosta Zertsekel
2013-01-10 15:57 ` Kosta Zertsekel
2013-01-10 17:12 ` Florian Fainelli
2013-01-10 17:12 ` Florian Fainelli
2013-01-10 12:17 ` Fix phy_init for Marvell network eth driver Jason Cooper
2013-01-10 12:17 ` Jason Cooper
2013-01-10 12:24 ` Andrew Lunn [this message]
2013-01-10 12:24 ` Andrew Lunn
2013-01-10 12:27 ` Kosta Zertsekel
2013-01-10 12:27 ` Kosta Zertsekel
-- strict thread matches above, loose matches on Subject: below --
2013-01-10 10:04 Kosta Zertsekel
2013-01-10 10:04 ` Kosta Zertsekel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110122441.GQ3392@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.