All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Alan Stern <stern@rowland.harvard.edu>,
	Aaron Lu <aaron.lwe@gmail.com>, Jeff Wu <jeff.wu@amd.com>,
	linux-ide@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off
Date: Thu, 10 Jan 2013 11:56:10 -0800	[thread overview]
Message-ID: <20130110195610.GL20454@htj.dyndns.org> (raw)
In-Reply-To: <1357809870-18816-8-git-send-email-aaron.lu@intel.com>

On Thu, Jan 10, 2013 at 05:24:28PM +0800, Aaron Lu wrote:
> @@ -182,6 +182,13 @@ void zpodd_enable_run_wake(struct ata_device *dev)
>  {
>  	struct zpodd *zpodd = dev->zpodd;
>  
> +	/*
> +	 * Silence the media change poll, as we will be notified when
> +	 * user wants to use the ODD so there is no meaning to poll
> +	 * it when it is powered off
> +	 */
> +	dev->sdev->disable_disk_events = true;

What's the synchronization rule for this field?

Thanks.

-- 
tejun

  reply	other threads:[~2013-01-10 19:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10  9:24 [PATCH v12 0/9] ZPODD Patches Aaron Lu
2013-01-10  9:24 ` [PATCH v12 1/9] scsi: sr: support runtime pm Aaron Lu
2013-01-10  9:24 ` [PATCH v12 2/9] libata: identify and init ZPODD devices Aaron Lu
2013-01-10 19:47   ` Tejun Heo
2013-01-10  9:24 ` [PATCH v12 3/9] libata: move acpi notification code to zpodd Aaron Lu
2013-01-10 19:48   ` Tejun Heo
2013-01-10  9:24 ` [PATCH v12 4/9] libata: check zero power ready status for ZPODD Aaron Lu
2013-01-10 19:52   ` Tejun Heo
2013-01-11  2:00     ` Aaron Lu
2013-01-10  9:24 ` [PATCH v12 5/9] libata: handle power transition of ODD Aaron Lu
2013-01-10 19:54   ` Tejun Heo
2013-01-10  9:24 ` [PATCH v12 6/9] libata: expose pm qos flags for ata device Aaron Lu
2013-01-10 19:55   ` Tejun Heo
2013-01-10  9:24 ` [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off Aaron Lu
2013-01-10 19:56   ` Tejun Heo [this message]
2013-01-11  2:11     ` Aaron Lu
2013-01-11  2:17       ` Tejun Heo
2013-01-11  3:16         ` Aaron Lu
2013-01-11 18:44           ` Tejun Heo
2013-01-14 18:01             ` Jeff Garzik
2013-01-15  7:12               ` Aaron Lu
2013-01-10  9:24 ` [PATCH v12 8/9] libata: do not suspend port if normal ODD is attached Aaron Lu
2013-01-10 19:57   ` Tejun Heo
2013-01-10  9:24 ` [PATCH v12 9/9] scsi: remove can_power_off flag from scsi_device Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130110195610.GL20454@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aaron.lu@intel.com \
    --cc=aaron.lwe@gmail.com \
    --cc=jeff.wu@amd.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.