From: Aaron Lu <aaron.lu@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <tj@kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alan Stern <stern@rowland.harvard.edu>,
Aaron Lu <aaron.lwe@gmail.com>, Jeff Wu <jeff.wu@amd.com>,
linux-ide@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off
Date: Tue, 15 Jan 2013 15:12:42 +0800 [thread overview]
Message-ID: <20130115071242.GA16590@aaronlu.sh.intel.com> (raw)
In-Reply-To: <50F4480B.7050001@pobox.com>
On Mon, Jan 14, 2013 at 01:01:47PM -0500, Jeff Garzik wrote:
> On 01/11/2013 01:44 PM, Tejun Heo wrote:
> >Hello,
> >
> >On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote:
> >>OK, will make it atomic in next version, thanks for the advice.
> >>
> >>Perhaps I can add two scsi helper functions in scsi_lib.c like:
> >>
> >>void sdev_disable_disk_events(struct scsi_device *sdev)
> >>{
> >> atomic_inc(&sdev->disk_events_disable_depth);
> >>}
> >>
> >>void sdev_enable_disk_events(struct scsi_device *sdev)
> >>{
> >> if (WARN_ON_ONCE(atomic_read(&sdev->disk_events_disable_depth) <= 0))
> >> return;
> >> atomic_dec(&sdev->disk_events_disable_depth);
> >>}
> >>
> >>And call them in ATA layer. Do you like this?
> >
> >Sounds good to me. James, how does the series look to you?
>
> Indeed. Want James' Acked-by for patch #1.
>
> I think it's ready. It can go into libata-dev.git #upstream, and be
> reverted prior to Linus push if James NAKs.
Great! Thanks.
I'll incorporate Tejun's suggestions into v13 and send them out soon.
-Aaron
next prev parent reply other threads:[~2013-01-15 7:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 9:24 [PATCH v12 0/9] ZPODD Patches Aaron Lu
2013-01-10 9:24 ` [PATCH v12 1/9] scsi: sr: support runtime pm Aaron Lu
2013-01-10 9:24 ` [PATCH v12 2/9] libata: identify and init ZPODD devices Aaron Lu
2013-01-10 19:47 ` Tejun Heo
2013-01-10 9:24 ` [PATCH v12 3/9] libata: move acpi notification code to zpodd Aaron Lu
2013-01-10 19:48 ` Tejun Heo
2013-01-10 9:24 ` [PATCH v12 4/9] libata: check zero power ready status for ZPODD Aaron Lu
2013-01-10 19:52 ` Tejun Heo
2013-01-11 2:00 ` Aaron Lu
2013-01-10 9:24 ` [PATCH v12 5/9] libata: handle power transition of ODD Aaron Lu
2013-01-10 19:54 ` Tejun Heo
2013-01-10 9:24 ` [PATCH v12 6/9] libata: expose pm qos flags for ata device Aaron Lu
2013-01-10 19:55 ` Tejun Heo
2013-01-10 9:24 ` [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off Aaron Lu
2013-01-10 19:56 ` Tejun Heo
2013-01-11 2:11 ` Aaron Lu
2013-01-11 2:17 ` Tejun Heo
2013-01-11 3:16 ` Aaron Lu
2013-01-11 18:44 ` Tejun Heo
2013-01-14 18:01 ` Jeff Garzik
2013-01-15 7:12 ` Aaron Lu [this message]
2013-01-10 9:24 ` [PATCH v12 8/9] libata: do not suspend port if normal ODD is attached Aaron Lu
2013-01-10 19:57 ` Tejun Heo
2013-01-10 9:24 ` [PATCH v12 9/9] scsi: remove can_power_off flag from scsi_device Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115071242.GA16590@aaronlu.sh.intel.com \
--to=aaron.lu@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=aaron.lwe@gmail.com \
--cc=jeff.wu@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.