* [patch] tg3: missing break statement in tg3_get_5720_nvram_info()
@ 2013-01-11 6:57 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-01-11 6:57 UTC (permalink / raw)
To: Michael Chan
Cc: Matt Carlson, Grant Likely, Rob Herring, netdev,
devicetree-discuss, kernel-janitors
There is a missing break statement so FLASH_5762_EEPROM_HD gets treated
like FLASH_5762_EEPROM_LD.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next.
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index bc4d989..642764e 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -13726,8 +13726,10 @@ static void tg3_get_5720_nvram_info(struct tg3 *tp)
switch (nvmpinstrp) {
case FLASH_5762_EEPROM_HD:
nvmpinstrp = FLASH_5720_EEPROM_HD;
+ break;
case FLASH_5762_EEPROM_LD:
nvmpinstrp = FLASH_5720_EEPROM_LD;
+ break;
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] tg3: missing break statement in tg3_get_5720_nvram_info()
@ 2013-01-11 6:57 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-01-11 6:57 UTC (permalink / raw)
To: Michael Chan
Cc: Matt Carlson, Grant Likely, Rob Herring, netdev,
devicetree-discuss, kernel-janitors
There is a missing break statement so FLASH_5762_EEPROM_HD gets treated
like FLASH_5762_EEPROM_LD.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next.
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index bc4d989..642764e 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -13726,8 +13726,10 @@ static void tg3_get_5720_nvram_info(struct tg3 *tp)
switch (nvmpinstrp) {
case FLASH_5762_EEPROM_HD:
nvmpinstrp = FLASH_5720_EEPROM_HD;
+ break;
case FLASH_5762_EEPROM_LD:
nvmpinstrp = FLASH_5720_EEPROM_LD;
+ break;
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] tg3: missing break statement in tg3_get_5720_nvram_info()
2013-01-11 6:57 ` Dan Carpenter
@ 2013-01-11 7:00 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-01-11 7:00 UTC (permalink / raw)
To: dan.carpenter
Cc: mchan, mcarlson, grant.likely, rob.herring, netdev,
devicetree-discuss, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 11 Jan 2013 09:57:33 +0300
> There is a missing break statement so FLASH_5762_EEPROM_HD gets treated
> like FLASH_5762_EEPROM_LD.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] tg3: missing break statement in tg3_get_5720_nvram_info()
@ 2013-01-11 7:00 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-01-11 7:00 UTC (permalink / raw)
To: dan.carpenter
Cc: mchan, mcarlson, grant.likely, rob.herring, netdev,
devicetree-discuss, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 11 Jan 2013 09:57:33 +0300
> There is a missing break statement so FLASH_5762_EEPROM_HD gets treated
> like FLASH_5762_EEPROM_LD.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-11 7:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-11 6:57 [patch] tg3: missing break statement in tg3_get_5720_nvram_info() Dan Carpenter
2013-01-11 6:57 ` Dan Carpenter
2013-01-11 7:00 ` David Miller
2013-01-11 7:00 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.