* drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? [not found] <50f017f7.SoVcNexmm6uNvfQX%yuanhan.liu@linux.intel.com> @ 2013-01-11 14:03 ` Fengguang Wu 2013-01-11 14:08 ` Viresh Kumar 0 siblings, 1 reply; 4+ messages in thread From: Fengguang Wu @ 2013-01-11 14:03 UTC (permalink / raw) To: Viresh Kumar; +Cc: Rafael J. Wysocki, linux-pm [-- Attachment #1: Type: text/plain, Size: 1074 bytes --] Hi Viresh, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next head: f3bb59ab652c781155b1c5e42ef7e29bf936d86b commit: 536ff06aba714c1d2d53cfca86b1a2e455842387 cpufreq: Don't use cpu removed during cpufreq_driver_unregister date: 15 hours ago drivers/cpufreq/cpufreq.c:43:8: sparse: symbol 'cpufreq_cpu_data' was not declared. Should it be static? drivers/cpufreq/cpufreq.c:46:8: sparse: symbol 'cpufreq_cpu_governor' was not declared. Should it be static? >> drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? drivers/cpufreq/cpufreq.c:72:8: sparse: symbol 'cpufreq_policy_cpu' was not declared. Should it be static? drivers/cpufreq/cpufreq.c:73:8: sparse: symbol 'cpu_policy_rwsem' was not declared. Should it be static? Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation [-- Attachment #2: make-it-static-536ff06.diff --] [-- Type: text/x-diff, Size: 504 bytes --] diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 271d3be..26dbf40 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -48,7 +48,7 @@ static DEFINE_PER_CPU(char[CPUFREQ_NAME_LEN], cpufreq_cpu_governor); static DEFINE_SPINLOCK(cpufreq_driver_lock); /* Used when we unregister cpufreq driver */ -struct cpumask cpufreq_online_mask; +static struct cpumask cpufreq_online_mask; /* * cpu_policy_rwsem is a per CPU reader-writer semaphore designed to cure ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? 2013-01-11 14:03 ` drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? Fengguang Wu @ 2013-01-11 14:08 ` Viresh Kumar 2013-01-11 22:47 ` Rafael J. Wysocki 0 siblings, 1 reply; 4+ messages in thread From: Viresh Kumar @ 2013-01-11 14:08 UTC (permalink / raw) To: Fengguang Wu; +Cc: Rafael J. Wysocki, linux-pm On 11 January 2013 19:33, Fengguang Wu <fengguang.wu@intel.com> wrote: > FYI, there are new sparse warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > head: f3bb59ab652c781155b1c5e42ef7e29bf936d86b > commit: 536ff06aba714c1d2d53cfca86b1a2e455842387 cpufreq: Don't use cpu removed during cpufreq_driver_unregister > date: 15 hours ago > > drivers/cpufreq/cpufreq.c:43:8: sparse: symbol 'cpufreq_cpu_data' was not declared. Should it be static? > drivers/cpufreq/cpufreq.c:46:8: sparse: symbol 'cpufreq_cpu_governor' was not declared. Should it be static? >>> drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? > drivers/cpufreq/cpufreq.c:72:8: sparse: symbol 'cpufreq_policy_cpu' was not declared. Should it be static? > drivers/cpufreq/cpufreq.c:73:8: sparse: symbol 'cpu_policy_rwsem' was not declared. Should it be static? > > Please consider folding the attached diff :-) Thanks for the fix :) @Rafael: I hope you can apply that? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? 2013-01-11 14:08 ` Viresh Kumar @ 2013-01-11 22:47 ` Rafael J. Wysocki 2013-01-12 4:08 ` Viresh Kumar 0 siblings, 1 reply; 4+ messages in thread From: Rafael J. Wysocki @ 2013-01-11 22:47 UTC (permalink / raw) To: Viresh Kumar; +Cc: Fengguang Wu, Rafael J. Wysocki, linux-pm On Friday, January 11, 2013 07:38:26 PM Viresh Kumar wrote: > On 11 January 2013 19:33, Fengguang Wu <fengguang.wu@intel.com> wrote: > > FYI, there are new sparse warnings show up in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > > head: f3bb59ab652c781155b1c5e42ef7e29bf936d86b > > commit: 536ff06aba714c1d2d53cfca86b1a2e455842387 cpufreq: Don't use cpu removed during cpufreq_driver_unregister > > date: 15 hours ago > > > > drivers/cpufreq/cpufreq.c:43:8: sparse: symbol 'cpufreq_cpu_data' was not declared. Should it be static? > > drivers/cpufreq/cpufreq.c:46:8: sparse: symbol 'cpufreq_cpu_governor' was not declared. Should it be static? > >>> drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? > > drivers/cpufreq/cpufreq.c:72:8: sparse: symbol 'cpufreq_policy_cpu' was not declared. Should it be static? > > drivers/cpufreq/cpufreq.c:73:8: sparse: symbol 'cpu_policy_rwsem' was not declared. Should it be static? > > > > Please consider folding the attached diff :-) > > Thanks for the fix :) > @Rafael: I hope you can apply that? I could, but I prefer you to send me a fixed patch. :-) Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? 2013-01-11 22:47 ` Rafael J. Wysocki @ 2013-01-12 4:08 ` Viresh Kumar 0 siblings, 0 replies; 4+ messages in thread From: Viresh Kumar @ 2013-01-12 4:08 UTC (permalink / raw) To: Rafael J. Wysocki; +Cc: Fengguang Wu, Rafael J. Wysocki, linux-pm On 12 January 2013 04:17, Rafael J. Wysocki <rjw@sisk.pl> wrote: > I could, but I prefer you to send me a fixed patch. :-) Ok. I will post all the 5 patches again :) ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-12 4:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50f017f7.SoVcNexmm6uNvfQX%yuanhan.liu@linux.intel.com>
2013-01-11 14:03 ` drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? Fengguang Wu
2013-01-11 14:08 ` Viresh Kumar
2013-01-11 22:47 ` Rafael J. Wysocki
2013-01-12 4:08 ` Viresh Kumar
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.