All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH] resize2fs: add debug switch to use old online interface
Date: Fri, 11 Jan 2013 19:30:27 -0500	[thread overview]
Message-ID: <20130112003027.GA9550@thunk.org> (raw)
In-Reply-To: <50F05175.8060502@redhat.com>

On Fri, Jan 11, 2013 at 11:52:53AM -0600, Eric Sandeen wrote:
> --- a/resize/resize2fs.h
> +++ b/resize/resize2fs.h
> @@ -76,6 +76,8 @@ typedef struct ext2_sim_progress *ext2_sim_progmeter;
>  #define RESIZE_DEBUG_BMOVE		0x0002
>  #define RESIZE_DEBUG_INODEMAP		0x0004
>  #define RESIZE_DEBUG_ITABLEMOVE		0x0008
> +/* old online resize interface */
> +#define RESIZE_DEBUG_OLD		0x0010

0x0010 is already used for

#define RESIZE_DEBUG_RTRACK		0x0010

(which is very useful for performance tuning resize2fs).

I wonder if we would be better off using a environment variable for
this?  Mainly because currently, the current resize flags don't
actually change the behavior of resize2fs, but just add different
levels of debugging messages. 

						- Ted

  reply	other threads:[~2013-01-12  0:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 17:52 [PATCH] resize2fs: add debug switch to use old online interface Eric Sandeen
2013-01-12  0:30 ` Theodore Ts'o [this message]
2013-01-12  0:33   ` Eric Sandeen
2013-01-12 23:04     ` Theodore Ts'o
2013-01-14 12:10       ` Carlos Maiolino
2013-01-14 12:50         ` Theodore Ts'o
2013-01-14 13:09           ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130112003027.GA9550@thunk.org \
    --to=tytso@mit.edu \
    --cc=cmaiolino@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.