Re: [PATCH] resize2fs: add debug switch to use old online interface

[Eric Sandeen <sandeen@redhat.com>]

On 1/11/13 6:30 PM, Theodore Ts'o wrote:
> On Fri, Jan 11, 2013 at 11:52:53AM -0600, Eric Sandeen wrote:
>> --- a/resize/resize2fs.h
>> +++ b/resize/resize2fs.h
>> @@ -76,6 +76,8 @@ typedef struct ext2_sim_progress *ext2_sim_progmeter;
>>  #define RESIZE_DEBUG_BMOVE		0x0002
>>  #define RESIZE_DEBUG_INODEMAP		0x0004
>>  #define RESIZE_DEBUG_ITABLEMOVE		0x0008
>> +/* old online resize interface */
>> +#define RESIZE_DEBUG_OLD		0x0010
> 
> 0x0010 is already used for
> 
> #define RESIZE_DEBUG_RTRACK		0x0010
> 
> (which is very useful for performance tuning resize2fs).

Ugh, how did I miss that.  Sorry.

> I wonder if we would be better off using a environment variable for
> this?  Mainly because currently, the current resize flags don't
> actually change the behavior of resize2fs, but just add different
> levels of debugging messages. 

The mechanism doesn't matter to me, we just need to be able to test
it if the interface is in the kernel.  I had originally had an "-o"
option for "old interface" but that didn't seem great.

-Eric

> 
> 						- Ted
>