From: Mike Turquette <mturquette@linaro.org>
To: Paul Walmsley <paul@pwsan.com>, linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, b-cousson@ti.com
Subject: Re: [PATCH] ARM: OMAP4: clock/hwmod data: remove MODULEMODE entries in mux + gate combos
Date: Fri, 11 Jan 2013 18:53:19 -0800 [thread overview]
Message-ID: <20130112025319.4361.29079@quantum> (raw)
In-Reply-To: <alpine.DEB.2.00.1212172240101.29833@utopia.booyaka.com>
Quoting Paul Walmsley (2012-12-17 14:41:13)
> Convert all DEFINE_OMAP_MUX_GATE() combinations that list MODULEMODE
> registers in their gate arguments to DEFINE_OMAP_MUX(), dropping the
> MODULEMODE data. This is possible because the MODULEMODE bits control
> IP blocks, not clocks; and the hwmod code takes care of IP block
> control. Rename these clocks to reflect the original multiplexer name
> as specified in the comments. And convert the hwmod data to use the
> multiplexer clock name.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Benoît Cousson <b-cousson@ti.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> ---
>
> Seems to boot with omap2plus_defconfig, anyway.
>
It looks good to me, and I am happy to see fewer clocks in favor of
using the hwmods. However I did not test it.
Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: clock/hwmod data: remove MODULEMODE entries in mux + gate combos
Date: Fri, 11 Jan 2013 18:53:19 -0800 [thread overview]
Message-ID: <20130112025319.4361.29079@quantum> (raw)
In-Reply-To: <alpine.DEB.2.00.1212172240101.29833@utopia.booyaka.com>
Quoting Paul Walmsley (2012-12-17 14:41:13)
> Convert all DEFINE_OMAP_MUX_GATE() combinations that list MODULEMODE
> registers in their gate arguments to DEFINE_OMAP_MUX(), dropping the
> MODULEMODE data. This is possible because the MODULEMODE bits control
> IP blocks, not clocks; and the hwmod code takes care of IP block
> control. Rename these clocks to reflect the original multiplexer name
> as specified in the comments. And convert the hwmod data to use the
> multiplexer clock name.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Beno?t Cousson <b-cousson@ti.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> ---
>
> Seems to boot with omap2plus_defconfig, anyway.
>
It looks good to me, and I am happy to see fewer clocks in favor of
using the hwmods. However I did not test it.
Regards,
Mike
next prev parent reply other threads:[~2013-01-12 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 22:41 [PATCH] ARM: OMAP4: clock/hwmod data: remove MODULEMODE entries in mux + gate combos Paul Walmsley
2012-12-17 22:41 ` Paul Walmsley
2013-01-12 2:53 ` Mike Turquette [this message]
2013-01-12 2:53 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130112025319.4361.29079@quantum \
--to=mturquette@linaro.org \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.