From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Olof Johansson <olof@lixom.net>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
voice.shen@atmel.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH 0/2 v2] at91/ssc: fixes on ASoC tree for 3.8
Date: Sat, 12 Jan 2013 14:34:50 +0100 [thread overview]
Message-ID: <20130112133450.GF7360@game.jcrosoft.org> (raw)
In-Reply-To: <20130111195331.GA2533@quad.lixom.net>
On 11:53 Fri 11 Jan , Olof Johansson wrote:
> On Fri, Jan 11, 2013 at 07:39:49PM +0000, Mark Brown wrote:
> > On Fri, Jan 11, 2013 at 10:52:19AM -0800, Olof Johansson wrote:
> > > On Fri, Jan 11, 2013 at 6:08 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> > >
> > > > This material was designed to enter Mark's fixes queue, but as discussed with
> > > > Olof, we can imagine merging everything through arm-soc or split the series (of
> > > > 2 patches) and let them progress upstream separated (option that I do not like
> > > > even if I know that the consequences are not so dramatic).
> > > > So please, Olof, if you feel confortable with this series, tell us what you
> > > > prefer and we will make our best to make this material go forward...
> >
> > > You're setting yourself up for awkward merges. The driver change is
> > > strongly dependent on the device tree change by failing probe unless
> > > the device tree update is there, while before this patch, it still
> > > worked.
> >
> > This is partly my fault for getting grumpy about adding the bolier plate
> > code without error checking - overall Linus' change to do the get in the
> > core seems like the most sane approach here.
> >
> > > But to be honest, I don't think this is a fix, it's a feature that you
> > > just didn't include in time for the merge window. I don't really see
> > > them as appropriate 3.8 material at this point.
> >
> > Jean-Christophe has been most insistent that pinctrl support is now
> > manadatory for all AT91 systems using device tree.
>
> That's a noble goal but enforcing it early gives everyone a lot of pain, and
> quite honestly doesn't make sense. During transition it's better to be lenient
> and allow both old and new methods (without breakage), unless it causes
> significant extra churn.
except here we can not as the same ip manage gpio & pinctrl
so no choice we need to do the switch at once
and that's why we wait 1 more release to do the switch so erveryone can play
with it before
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Olof Johansson <olof@lixom.net>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
voice.shen@atmel.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH 0/2 v2] at91/ssc: fixes on ASoC tree for 3.8
Date: Sat, 12 Jan 2013 13:34:50 +0000 [thread overview]
Message-ID: <20130112133450.GF7360@game.jcrosoft.org> (raw)
In-Reply-To: <20130111195331.GA2533@quad.lixom.net>
On 11:53 Fri 11 Jan , Olof Johansson wrote:
> On Fri, Jan 11, 2013 at 07:39:49PM +0000, Mark Brown wrote:
> > On Fri, Jan 11, 2013 at 10:52:19AM -0800, Olof Johansson wrote:
> > > On Fri, Jan 11, 2013 at 6:08 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> > >
> > > > This material was designed to enter Mark's fixes queue, but as discussed with
> > > > Olof, we can imagine merging everything through arm-soc or split the series (of
> > > > 2 patches) and let them progress upstream separated (option that I do not like
> > > > even if I know that the consequences are not so dramatic).
> > > > So please, Olof, if you feel confortable with this series, tell us what you
> > > > prefer and we will make our best to make this material go forward...
> >
> > > You're setting yourself up for awkward merges. The driver change is
> > > strongly dependent on the device tree change by failing probe unless
> > > the device tree update is there, while before this patch, it still
> > > worked.
> >
> > This is partly my fault for getting grumpy about adding the bolier plate
> > code without error checking - overall Linus' change to do the get in the
> > core seems like the most sane approach here.
> >
> > > But to be honest, I don't think this is a fix, it's a feature that you
> > > just didn't include in time for the merge window. I don't really see
> > > them as appropriate 3.8 material at this point.
> >
> > Jean-Christophe has been most insistent that pinctrl support is now
> > manadatory for all AT91 systems using device tree.
>
> That's a noble goal but enforcing it early gives everyone a lot of pain, and
> quite honestly doesn't make sense. During transition it's better to be lenient
> and allow both old and new methods (without breakage), unless it causes
> significant extra churn.
except here we can not as the same ip manage gpio & pinctrl
so no choice we need to do the switch at once
and that's why we wait 1 more release to do the switch so erveryone can play
with it before
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2 v2] at91/ssc: fixes on ASoC tree for 3.8
Date: Sat, 12 Jan 2013 14:34:50 +0100 [thread overview]
Message-ID: <20130112133450.GF7360@game.jcrosoft.org> (raw)
In-Reply-To: <20130111195331.GA2533@quad.lixom.net>
On 11:53 Fri 11 Jan , Olof Johansson wrote:
> On Fri, Jan 11, 2013 at 07:39:49PM +0000, Mark Brown wrote:
> > On Fri, Jan 11, 2013 at 10:52:19AM -0800, Olof Johansson wrote:
> > > On Fri, Jan 11, 2013 at 6:08 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> > >
> > > > This material was designed to enter Mark's fixes queue, but as discussed with
> > > > Olof, we can imagine merging everything through arm-soc or split the series (of
> > > > 2 patches) and let them progress upstream separated (option that I do not like
> > > > even if I know that the consequences are not so dramatic).
> > > > So please, Olof, if you feel confortable with this series, tell us what you
> > > > prefer and we will make our best to make this material go forward...
> >
> > > You're setting yourself up for awkward merges. The driver change is
> > > strongly dependent on the device tree change by failing probe unless
> > > the device tree update is there, while before this patch, it still
> > > worked.
> >
> > This is partly my fault for getting grumpy about adding the bolier plate
> > code without error checking - overall Linus' change to do the get in the
> > core seems like the most sane approach here.
> >
> > > But to be honest, I don't think this is a fix, it's a feature that you
> > > just didn't include in time for the merge window. I don't really see
> > > them as appropriate 3.8 material at this point.
> >
> > Jean-Christophe has been most insistent that pinctrl support is now
> > manadatory for all AT91 systems using device tree.
>
> That's a noble goal but enforcing it early gives everyone a lot of pain, and
> quite honestly doesn't make sense. During transition it's better to be lenient
> and allow both old and new methods (without breakage), unless it causes
> significant extra churn.
except here we can not as the same ip manage gpio & pinctrl
so no choice we need to do the switch at once
and that's why we wait 1 more release to do the switch so erveryone can play
with it before
Best Regards,
J.
next prev parent reply other threads:[~2013-01-12 13:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 14:08 [PATCH 0/2 v2] at91/ssc: fixes on ASoC tree for 3.8 Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` [PATCH 1/2 v2] ARM: at91/dts: add pinctrl support for SSC peripheral Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` [PATCH 2/2 v2] ASoC: atmel-ssc: add pinctrl selection to driver Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 14:08 ` Nicolas Ferre
2013-01-11 18:52 ` [PATCH 0/2 v2] at91/ssc: fixes on ASoC tree for 3.8 Olof Johansson
2013-01-11 18:52 ` Olof Johansson
2013-01-11 18:52 ` Olof Johansson
2013-01-11 19:39 ` Mark Brown
2013-01-11 19:39 ` Mark Brown
2013-01-11 19:53 ` Olof Johansson
2013-01-11 19:53 ` Olof Johansson
2013-01-11 19:53 ` Olof Johansson
2013-01-12 13:34 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-01-12 13:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-12 13:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-12 0:04 ` Mark Brown
2013-01-12 0:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130112133450.GF7360@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.