* [PATCH] usb: Crucible Technologies COMET Caller ID - pid added.
@ 2013-01-13 18:20 Tomasz Mloduchowski
2013-01-13 19:25 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Mloduchowski @ 2013-01-13 18:20 UTC (permalink / raw)
To: jhovold; +Cc: gregkh, linux-usb, linux-kernel
From: Tomasz Mloduchowski <q@qdot.me>
Simple fix to add support for Crucible Technologies COMET Caller ID
USB decoder - a device containing FTDI USB/Serial converter chip,
handling 1200bps CallerID messages decoded from the phone line -
adding correct USB PID is sufficient.
Tested to apply cleanly and work flawlessly against 3.6.9, 3.7.0-rc8
and 3.8.0-rc3 on both amd64 and x86 arches.
Signed-off-by: Tomasz Mloduchowski <q@qdot.me>
---
diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c
linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c
--- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13
19:41:28.000000000 +0100
+++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13
19:49:27.239874311 +0100
@@ -875,6 +875,8 @@
{ USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID),
.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
{ USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) },
+ /* Crucible Devices */
+ { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) },
{ }, /* Optional parameter entry */
{ } /* Terminating entry */
};
diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h
linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h
--- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h
2013-01-13 19:41:28.000000000 +0100
+++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13
19:48:24.819996641 +0100
@@ -1259,3 +1259,9 @@
* ATI command output: Cinterion MC55i
*/
#define FTDI_CINTERION_MC55I_PID 0xA951
+
+/*
+ * Product: Comet Caller ID decoder
+ * Manufacturer: Crucible Technologies
+ */
+#define FTDI_CT_COMET_PID 0x8e08
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: Crucible Technologies COMET Caller ID - pid added. 2013-01-13 18:20 [PATCH] usb: Crucible Technologies COMET Caller ID - pid added Tomasz Mloduchowski @ 2013-01-13 19:25 ` Greg KH 2013-01-13 21:40 ` Tomasz Mloduchowski 0 siblings, 1 reply; 4+ messages in thread From: Greg KH @ 2013-01-13 19:25 UTC (permalink / raw) To: Tomasz Mloduchowski; +Cc: jhovold, linux-usb, linux-kernel On Sun, Jan 13, 2013 at 07:20:27PM +0100, Tomasz Mloduchowski wrote: > From: Tomasz Mloduchowski <q@qdot.me> > > Simple fix to add support for Crucible Technologies COMET Caller ID > USB decoder - a device containing FTDI USB/Serial converter chip, > handling 1200bps CallerID messages decoded from the phone line - > adding correct USB PID is sufficient. > > Tested to apply cleanly and work flawlessly against 3.6.9, 3.7.0-rc8 > and 3.8.0-rc3 on both amd64 and x86 arches. > > Signed-off-by: Tomasz Mloduchowski <q@qdot.me> > --- > diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c > linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c > --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13 > 19:41:28.000000000 +0100 > +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13 > 19:49:27.239874311 +0100 > @@ -875,6 +875,8 @@ > { USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID), > .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, > { USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) }, > + /* Crucible Devices */ > + { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) }, > { }, /* Optional parameter entry */ > { } /* Terminating entry */ > }; The patch is line-wrapped and all of the tabs are converted to spaces, both of which are keeping this patch from being able to be applied :( Care to fix your email client and resend this so that I can apply it? thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: Crucible Technologies COMET Caller ID - pid added. 2013-01-13 19:25 ` Greg KH @ 2013-01-13 21:40 ` Tomasz Mloduchowski 2013-01-13 21:20 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Tomasz Mloduchowski @ 2013-01-13 21:40 UTC (permalink / raw) To: Greg KH; +Cc: jhovold, linux-usb, linux-kernel On 01/13/13 20:25, Greg KH wrote: > On Sun, Jan 13, 2013 at 07:20:27PM +0100, Tomasz Mloduchowski wrote: >> From: Tomasz Mloduchowski <q@qdot.me> >> >> Simple fix to add support for Crucible Technologies COMET Caller ID >> USB decoder - a device containing FTDI USB/Serial converter chip, >> handling 1200bps CallerID messages decoded from the phone line - >> adding correct USB PID is sufficient. >> >> Tested to apply cleanly and work flawlessly against 3.6.9, 3.7.0-rc8 >> and 3.8.0-rc3 on both amd64 and x86 arches. >> >> Signed-off-by: Tomasz Mloduchowski <q@qdot.me> >> --- >> diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c >> linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c >> --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13 >> 19:41:28.000000000 +0100 >> +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13 >> 19:49:27.239874311 +0100 >> @@ -875,6 +875,8 @@ >> { USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID), >> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, >> { USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) }, >> + /* Crucible Devices */ >> + { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) }, >> { }, /* Optional parameter entry */ >> { } /* Terminating entry */ >> }; > > The patch is line-wrapped and all of the tabs are converted to spaces, > both of which are keeping this patch from being able to be applied :( > > Care to fix your email client and resend this so that I can apply it? > > thanks, > > greg k-h > No problem - this should send correctly now . Best, Tomasz diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13 19:41:28.000000000 +0100 +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13 19:49:27.239874311 +0100 @@ -875,6 +875,8 @@ { USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID), .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, { USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) }, + /* Crucible Devices */ + { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) }, { }, /* Optional parameter entry */ { } /* Terminating entry */ }; diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13 19:41:28.000000000 +0100 +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13 19:48:24.819996641 +0100 @@ -1259,3 +1259,9 @@ * ATI command output: Cinterion MC55i */ #define FTDI_CINTERION_MC55I_PID 0xA951 + +/* + * Product: Comet Caller ID decoder + * Manufacturer: Crucible Technologies + */ +#define FTDI_CT_COMET_PID 0x8e08 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: Crucible Technologies COMET Caller ID - pid added. 2013-01-13 21:40 ` Tomasz Mloduchowski @ 2013-01-13 21:20 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2013-01-13 21:20 UTC (permalink / raw) To: Tomasz Mloduchowski; +Cc: jhovold, linux-usb, linux-kernel On Sun, Jan 13, 2013 at 10:40:20PM +0100, Tomasz Mloduchowski wrote: > On 01/13/13 20:25, Greg KH wrote: > > On Sun, Jan 13, 2013 at 07:20:27PM +0100, Tomasz Mloduchowski wrote: > >> From: Tomasz Mloduchowski <q@qdot.me> > >> > >> Simple fix to add support for Crucible Technologies COMET Caller ID > >> USB decoder - a device containing FTDI USB/Serial converter chip, > >> handling 1200bps CallerID messages decoded from the phone line - > >> adding correct USB PID is sufficient. > >> > >> Tested to apply cleanly and work flawlessly against 3.6.9, 3.7.0-rc8 > >> and 3.8.0-rc3 on both amd64 and x86 arches. > >> > >> Signed-off-by: Tomasz Mloduchowski <q@qdot.me> > >> --- > >> diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c > >> linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c > >> --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13 > >> 19:41:28.000000000 +0100 > >> +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13 > >> 19:49:27.239874311 +0100 > >> @@ -875,6 +875,8 @@ > >> { USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID), > >> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, > >> { USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) }, > >> + /* Crucible Devices */ > >> + { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) }, > >> { }, /* Optional parameter entry */ > >> { } /* Terminating entry */ > >> }; > > > > The patch is line-wrapped and all of the tabs are converted to spaces, > > both of which are keeping this patch from being able to be applied :( > > > > Care to fix your email client and resend this so that I can apply it? > > > > thanks, > > > > greg k-h > > > > > No problem - this should send correctly now . Yes it did. So can you resend it in the original format (correct changelog entry and signed-off-by: line), so that I can apply it without having to edit the patch by hand? Also: > diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c > --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13 19:41:28.000000000 +0100 > +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13 19:49:27.239874311 +0100 > @@ -875,6 +875,8 @@ > { USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID), > .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, > { USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) }, > + /* Crucible Devices */ > + { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) }, > { }, /* Optional parameter entry */ > { } /* Terminating entry */ > }; > diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h > --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13 19:41:28.000000000 +0100 > +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13 19:48:24.819996641 +0100 > @@ -1259,3 +1259,9 @@ > * ATI command output: Cinterion MC55i > */ > #define FTDI_CINTERION_MC55I_PID 0xA951 > + > +/* > + * Product: Comet Caller ID decoder > + * Manufacturer: Crucible Technologies > + */ > +#define FTDI_CT_COMET_PID 0x8e08 Don't you want a tab after the FTDI_CT_COMET_PID and before the number? thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-13 21:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-13 18:20 [PATCH] usb: Crucible Technologies COMET Caller ID - pid added Tomasz Mloduchowski 2013-01-13 19:25 ` Greg KH 2013-01-13 21:40 ` Tomasz Mloduchowski 2013-01-13 21:20 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.