From: Andrew Lunn <andrew@lunn.ch>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
gmbnomis@gmail.com, linux-mmc@vger.kernel.org, cjb@laptop.org,
linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] mmc: mvsdio: Replace IS_ERR_OR_NULL() with IS_ERR()
Date: Sun, 13 Jan 2013 22:42:59 +0100 [thread overview]
Message-ID: <20130113214259.GE17242@lunn.ch> (raw)
In-Reply-To: <20130113204348.GR13433@titan.lakedaemon.net>
On Sun, Jan 13, 2013 at 03:43:48PM -0500, Jason Cooper wrote:
> On Fri, Jan 11, 2013 at 08:27:52AM +0100, Andrew Lunn wrote:
> > A NULL is a valid clk cookie, so we should not be tested with
> > IS_ERR_OR_NULL(). Replace it with IS_ERR().
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >
> > This patch depends on Thomas Petazzoni DT patches for mvsdio, which changed
> > the order of resource allocation etc.
>
> grrr, I'm seeing fixes depending on features :( Any way to avoid that?
>
> In light of Russell's comments, shall I wait for a v3? All of Thomas'
> mvsdio work is now waiting on this. I'd like to get that in as early as
> possible.
Well, im guessing doing the fixes first will require changes to Thomas
features.
Did you try putting Russells patch in first? How bad are the
conflicts?
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mmc: mvsdio: Replace IS_ERR_OR_NULL() with IS_ERR()
Date: Sun, 13 Jan 2013 22:42:59 +0100 [thread overview]
Message-ID: <20130113214259.GE17242@lunn.ch> (raw)
In-Reply-To: <20130113204348.GR13433@titan.lakedaemon.net>
On Sun, Jan 13, 2013 at 03:43:48PM -0500, Jason Cooper wrote:
> On Fri, Jan 11, 2013 at 08:27:52AM +0100, Andrew Lunn wrote:
> > A NULL is a valid clk cookie, so we should not be tested with
> > IS_ERR_OR_NULL(). Replace it with IS_ERR().
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >
> > This patch depends on Thomas Petazzoni DT patches for mvsdio, which changed
> > the order of resource allocation etc.
>
> grrr, I'm seeing fixes depending on features :( Any way to avoid that?
>
> In light of Russell's comments, shall I wait for a v3? All of Thomas'
> mvsdio work is now waiting on this. I'd like to get that in as early as
> possible.
Well, im guessing doing the fixes first will require changes to Thomas
features.
Did you try putting Russells patch in first? How bad are the
conflicts?
Andrew
next prev parent reply other threads:[~2013-01-13 21:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 20:29 [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR() Andrew Lunn
2013-01-10 20:29 ` Andrew Lunn
2013-01-10 20:49 ` Jason Cooper
2013-01-10 20:49 ` Jason Cooper
2013-01-11 0:43 ` Simon Baatz
2013-01-11 0:43 ` Simon Baatz
2013-01-11 7:27 ` [PATCH v2] mmc: mvsdio: Replace IS_ERR_OR_NULL() " Andrew Lunn
2013-01-11 7:27 ` Andrew Lunn
2013-01-13 20:43 ` Jason Cooper
2013-01-13 20:43 ` Jason Cooper
2013-01-13 21:42 ` Andrew Lunn [this message]
2013-01-13 21:42 ` Andrew Lunn
2013-01-11 11:02 ` [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is " Russell King - ARM Linux
2013-01-11 11:02 ` Russell King - ARM Linux
2013-01-11 11:09 ` Thomas Petazzoni
2013-01-11 11:09 ` Thomas Petazzoni
2013-01-11 11:11 ` Russell King - ARM Linux
2013-01-11 11:11 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130113214259.GE17242@lunn.ch \
--to=andrew@lunn.ch \
--cc=cjb@laptop.org \
--cc=gmbnomis@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.