From: Felipe Balbi <balbi@ti.com>
To: Peter Chen <peter.chen@freescale.com>
Cc: r58472@freescale.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, balbi@ti.com, kernel@pengutronix.de,
shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h
Date: Mon, 14 Jan 2013 09:48:58 +0200 [thread overview]
Message-ID: <20130114074858.GA10176@arwen.pp.htv.fi> (raw)
In-Reply-To: <1358147897-8599-1-git-send-email-peter.chen@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi,
On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote:
> It changes the driver to use platform_device_id rather than cpu_is_xxx
> to determine the SoC type, and updates the platform code accordingly.
>
> Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable.
> Tested at mx51 bbg board, it works ok after enable phy clock
> (Need another patch to fix this problem)
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
not good for -rc. You have to break this down as you're solving at least
three different problems with this patch.
Besides there are parts which are not related to the build break.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h
Date: Mon, 14 Jan 2013 09:48:58 +0200 [thread overview]
Message-ID: <20130114074858.GA10176@arwen.pp.htv.fi> (raw)
In-Reply-To: <1358147897-8599-1-git-send-email-peter.chen@freescale.com>
Hi,
On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote:
> It changes the driver to use platform_device_id rather than cpu_is_xxx
> to determine the SoC type, and updates the platform code accordingly.
>
> Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable.
> Tested at mx51 bbg board, it works ok after enable phy clock
> (Need another patch to fix this problem)
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
not good for -rc. You have to break this down as you're solving at least
three different problems with this patch.
Besides there are parts which are not related to the build break.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130114/abb4c364/attachment-0001.sig>
next prev parent reply other threads:[~2013-01-14 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 7:18 [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h Peter Chen
2013-01-14 7:18 ` Peter Chen
2013-01-14 7:48 ` Felipe Balbi [this message]
2013-01-14 7:48 ` Felipe Balbi
2013-01-14 8:17 ` Peter Chen
2013-01-14 8:17 ` Peter Chen
2013-01-14 8:50 ` Felipe Balbi
2013-01-14 8:50 ` Felipe Balbi
2013-01-14 9:13 ` Peter Chen
2013-01-14 9:13 ` Peter Chen
2013-01-14 9:18 ` Felipe Balbi
2013-01-14 9:18 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114074858.GA10176@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peter.chen@freescale.com \
--cc=r58472@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.