From: Peter Chen <peter.chen@freescale.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: r58472@freescale.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, balbi@ti.com, kernel@pengutronix.de,
shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap
Date: Mon, 14 Jan 2013 21:16:20 +0800 [thread overview]
Message-ID: <20130114131619.GC30157@nchen-desktop> (raw)
In-Reply-To: <20130114131056.GB23505@n2100.arm.linux.org.uk>
On Mon, Jan 14, 2013 at 01:10:56PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote:
> > @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype,
> > struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data;
> > if (devtype == IMX35_UDC) {
> > unsigned int v;
> > + void __iomem *phy_regs = ioremap((unsigned long)pdata->regs +
> > + MX35_USBPHYCTRL_OFFSET, 512);
>
> Consider that ioremap() can fail.
>
Thanks, will check NULL pointer.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap
Date: Mon, 14 Jan 2013 21:16:20 +0800 [thread overview]
Message-ID: <20130114131619.GC30157@nchen-desktop> (raw)
In-Reply-To: <20130114131056.GB23505@n2100.arm.linux.org.uk>
On Mon, Jan 14, 2013 at 01:10:56PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote:
> > @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype,
> > struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data;
> > if (devtype == IMX35_UDC) {
> > unsigned int v;
> > + void __iomem *phy_regs = ioremap((unsigned long)pdata->regs +
> > + MX35_USBPHYCTRL_OFFSET, 512);
>
> Consider that ioremap() can fail.
>
Thanks, will check NULL pointer.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-01-14 13:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 10:12 [PATCH v3 0/3] Fix the Build error for fsl_mxc_udc.c Peter Chen
2013-01-14 10:12 ` Peter Chen
2013-01-14 10:12 ` [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id Peter Chen
2013-01-14 10:12 ` Peter Chen
2013-01-14 10:16 ` Felipe Balbi
2013-01-14 10:16 ` Felipe Balbi
2013-01-14 10:18 ` Marc Kleine-Budde
2013-01-14 10:18 ` Marc Kleine-Budde
2013-01-14 10:24 ` Felipe Balbi
2013-01-14 10:24 ` Felipe Balbi
2013-01-14 10:34 ` Marc Kleine-Budde
2013-01-14 10:34 ` Marc Kleine-Budde
2013-01-14 10:39 ` Felipe Balbi
2013-01-14 10:39 ` Felipe Balbi
2013-01-14 10:50 ` Marc Kleine-Budde
2013-01-14 10:50 ` Marc Kleine-Budde
2013-01-14 10:53 ` Felipe Balbi
2013-01-14 10:53 ` Felipe Balbi
2013-01-14 11:03 ` Marc Kleine-Budde
2013-01-14 11:03 ` Marc Kleine-Budde
2013-01-14 11:06 ` Felipe Balbi
2013-01-14 11:06 ` Felipe Balbi
2013-01-14 12:56 ` Peter Chen
2013-01-14 12:56 ` Peter Chen
2013-01-14 17:40 ` Felipe Balbi
2013-01-14 17:40 ` Felipe Balbi
2013-01-14 17:54 ` Marc Kleine-Budde
2013-01-14 17:54 ` Marc Kleine-Budde
2013-01-14 17:57 ` Felipe Balbi
2013-01-14 17:57 ` Felipe Balbi
2013-01-15 1:31 ` Peter Chen
2013-01-15 1:31 ` Peter Chen
2013-01-14 10:12 ` [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap Peter Chen
2013-01-14 10:12 ` Peter Chen
2013-01-14 10:17 ` Felipe Balbi
2013-01-14 10:17 ` Felipe Balbi
2013-01-14 12:58 ` Peter Chen
2013-01-14 12:58 ` Peter Chen
2013-01-14 13:10 ` Russell King - ARM Linux
2013-01-14 13:10 ` Russell King - ARM Linux
2013-01-14 13:16 ` Peter Chen [this message]
2013-01-14 13:16 ` Peter Chen
2013-01-14 10:12 ` [PATCH v3 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc Peter Chen
2013-01-14 10:12 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114131619.GC30157@nchen-desktop \
--to=peter.chen@freescale.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.