From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Do not call abstract_cpu::wiggle for GPU
Date: Mon, 14 Jan 2013 22:58:06 +0300 [thread overview]
Message-ID: <20130114195806.GA3255@swordfish> (raw)
In-Reply-To: 1358181718-17761-1-git-send-email-jskarvad@redhat.com
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On (01/14/13 17:41), Jaroslav Škarvada wrote:
> first_cpu is uninitialized there which results in:
> open("/sys/devices/system/cpu/cpu1330597711/cpufreq/scaling_max_freq", O_RDONLY)
> ---
> src/cpu/intel_cpus.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/cpu/intel_cpus.h b/src/cpu/intel_cpus.h
> index 1949af1..752e8d0 100644
> --- a/src/cpu/intel_cpus.h
> +++ b/src/cpu/intel_cpus.h
> @@ -158,5 +158,6 @@ public:
> virtual char * fill_cstate_line(int line_nr, char *buffer, const char *separator);
> virtual int has_pstate_level(int level) { return 0; };
> virtual int has_pstates(void) { return 0; };
> + virtual void wiggle(void) { };
>
> };
>
good catch. thanks.
-ss
next reply other threads:[~2013-01-14 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 19:58 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-31 23:28 [Powertop] [PATCH] Do not call abstract_cpu::wiggle for GPU Kristen Carlson Accardi
2013-01-14 16:41
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114195806.GA3255@swordfish \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.