* [Powertop] [PATCH] Do not call abstract_cpu::wiggle for GPU
@ 2013-01-14 16:41
0 siblings, 0 replies; 3+ messages in thread
From: @ 2013-01-14 16:41 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
first_cpu is uninitialized there which results in:
open("/sys/devices/system/cpu/cpu1330597711/cpufreq/scaling_max_freq", O_RDONLY)
---
src/cpu/intel_cpus.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu/intel_cpus.h b/src/cpu/intel_cpus.h
index 1949af1..752e8d0 100644
--- a/src/cpu/intel_cpus.h
+++ b/src/cpu/intel_cpus.h
@@ -158,5 +158,6 @@ public:
virtual char * fill_cstate_line(int line_nr, char *buffer, const char *separator);
virtual int has_pstate_level(int level) { return 0; };
virtual int has_pstates(void) { return 0; };
+ virtual void wiggle(void) { };
};
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Powertop] [PATCH] Do not call abstract_cpu::wiggle for GPU
@ 2013-01-14 19:58 Sergey Senozhatsky
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2013-01-14 19:58 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On (01/14/13 17:41), Jaroslav Škarvada wrote:
> first_cpu is uninitialized there which results in:
> open("/sys/devices/system/cpu/cpu1330597711/cpufreq/scaling_max_freq", O_RDONLY)
> ---
> src/cpu/intel_cpus.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/cpu/intel_cpus.h b/src/cpu/intel_cpus.h
> index 1949af1..752e8d0 100644
> --- a/src/cpu/intel_cpus.h
> +++ b/src/cpu/intel_cpus.h
> @@ -158,5 +158,6 @@ public:
> virtual char * fill_cstate_line(int line_nr, char *buffer, const char *separator);
> virtual int has_pstate_level(int level) { return 0; };
> virtual int has_pstates(void) { return 0; };
> + virtual void wiggle(void) { };
>
> };
>
good catch. thanks.
-ss
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Powertop] [PATCH] Do not call abstract_cpu::wiggle for GPU
@ 2013-01-31 23:28 Kristen Carlson Accardi
0 siblings, 0 replies; 3+ messages in thread
From: Kristen Carlson Accardi @ 2013-01-31 23:28 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Mon, 14 Jan 2013 17:41:58 +0100
Jaroslav Škarvada <jskarvad(a)redhat.com> wrote:
> first_cpu is uninitialized there which results in:
> open("/sys/devices/system/cpu/cpu1330597711/cpufreq/scaling_max_freq",
> O_RDONLY) ---
> src/cpu/intel_cpus.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/cpu/intel_cpus.h b/src/cpu/intel_cpus.h
> index 1949af1..752e8d0 100644
> --- a/src/cpu/intel_cpus.h
> +++ b/src/cpu/intel_cpus.h
> @@ -158,5 +158,6 @@ public:
> virtual char * fill_cstate_line(int line_nr, char *buffer,
> const char *separator); virtual int has_pstate_level(int
> level) { return 0; }; virtual int has_pstates(void) { return
> 0; };
> + virtual void wiggle(void) { };
>
> };
Applied, thanks.
Kristen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-31 23:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-14 19:58 [Powertop] [PATCH] Do not call abstract_cpu::wiggle for GPU Sergey Senozhatsky
-- strict thread matches above, loose matches on Subject: below --
2013-01-31 23:28 Kristen Carlson Accardi
2013-01-14 16:41
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.