All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Terje Bergstrom <tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	airlied-cv59FeDIM0c@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv5 0/8] Support for Tegra 2D hardware
Date: Tue, 15 Jan 2013 12:33:48 +0100	[thread overview]
Message-ID: <20130115113347.GC18119@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1358249182-17486-1-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

On Tue, Jan 15, 2013 at 01:26:14PM +0200, Terje Bergstrom wrote:
> This set of patches adds support for Tegra20 and Tegra30 host1x and
> 2D. It is based on linux-next-20130114.
> 
> The fifth version merges DRM and host1x drivers into one driver. This
> allowed moving include/linux/host1x.h back into the driver and removed
> the need for a dummy platform device. This version also uses the code
> from tegradrm driver almost as is, so there are a lot less actual code
> changes.
> 
> This patch set does not have the host1x allocator, but it uses CMA
> helpers for memory management.
> 
> host1x is the driver that controls host1x hardware. It supports
> host1x command channels, synchronization, and memory management. It
> is sectioned into logical driver under drivers/gpu/host1x and
> physical driver under drivers/host1x/hw. The physical driver is
> compiled with the hardware headers of the particular host1x version.
> 
> The hardware units are described (briefly) in the Tegra2 TRM. Wiki
> page https://gitorious.org/linux-tegra-drm/pages/Host1xIntroduction
> also contains a short description of the functionality.
> 
> The patch set merges tegradrm into host1x and adds 2D driver, which
> uses host1x channels and sync points. The patch set also adds user
> space API to tegradrm for accessing host1x and 2D.
> 
> Terje Bergstrom (8):
>   gpu: host1x: Add host1x driver
>   gpu: host1x: Add syncpoint wait and interrupts
>   gpu: host1x: Add channel support
>   gpu: host1x: Add debug support
>   drm: tegra: Move drm to live under host1x
>   gpu: host1x: Remove second host1x driver
>   ARM: tegra: Add board data and 2D clocks
>   drm: tegra: Add gr2d device

Hi Terje,

Just by a quick glance this looks like we're getting closer. To make
reviewing easier, would you mind resending patches formatted with -M so
that git actually detects that tegra-drm was moved. That should make it
easy to see what exactly needed to be changed besides the relocation.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Terje Bergstrom <tbergstrom@nvidia.com>
Cc: amerilainen@nvidia.com, airlied@linux.ie,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 0/8] Support for Tegra 2D hardware
Date: Tue, 15 Jan 2013 12:33:48 +0100	[thread overview]
Message-ID: <20130115113347.GC18119@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1358249182-17486-1-git-send-email-tbergstrom@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

On Tue, Jan 15, 2013 at 01:26:14PM +0200, Terje Bergstrom wrote:
> This set of patches adds support for Tegra20 and Tegra30 host1x and
> 2D. It is based on linux-next-20130114.
> 
> The fifth version merges DRM and host1x drivers into one driver. This
> allowed moving include/linux/host1x.h back into the driver and removed
> the need for a dummy platform device. This version also uses the code
> from tegradrm driver almost as is, so there are a lot less actual code
> changes.
> 
> This patch set does not have the host1x allocator, but it uses CMA
> helpers for memory management.
> 
> host1x is the driver that controls host1x hardware. It supports
> host1x command channels, synchronization, and memory management. It
> is sectioned into logical driver under drivers/gpu/host1x and
> physical driver under drivers/host1x/hw. The physical driver is
> compiled with the hardware headers of the particular host1x version.
> 
> The hardware units are described (briefly) in the Tegra2 TRM. Wiki
> page https://gitorious.org/linux-tegra-drm/pages/Host1xIntroduction
> also contains a short description of the functionality.
> 
> The patch set merges tegradrm into host1x and adds 2D driver, which
> uses host1x channels and sync points. The patch set also adds user
> space API to tegradrm for accessing host1x and 2D.
> 
> Terje Bergstrom (8):
>   gpu: host1x: Add host1x driver
>   gpu: host1x: Add syncpoint wait and interrupts
>   gpu: host1x: Add channel support
>   gpu: host1x: Add debug support
>   drm: tegra: Move drm to live under host1x
>   gpu: host1x: Remove second host1x driver
>   ARM: tegra: Add board data and 2D clocks
>   drm: tegra: Add gr2d device

Hi Terje,

Just by a quick glance this looks like we're getting closer. To make
reviewing easier, would you mind resending patches formatted with -M so
that git actually detects that tegra-drm was moved. That should make it
easy to see what exactly needed to be changed besides the relocation.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-01-15 11:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15 11:26 [PATCHv5 0/8] Support for Tegra 2D hardware Terje Bergstrom
2013-01-15 11:26 ` Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 1/8] gpu: host1x: Add host1x driver Terje Bergstrom
2013-01-15 11:26   ` Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 2/8] gpu: host1x: Add syncpoint wait and interrupts Terje Bergstrom
2013-01-15 11:26   ` Terje Bergstrom
2013-01-15 11:26 ` [PATCHv5 4/8] gpu: host1x: Add debug support Terje Bergstrom
2013-01-15 11:26   ` Terje Bergstrom
     [not found] ` <1358249182-17486-1-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-15 11:26   ` [PATCHv5 3/8] gpu: host1x: Add channel support Terje Bergstrom
2013-01-15 11:26     ` Terje Bergstrom
2013-01-15 11:26   ` [PATCHv5 5/8] drm: tegra: Move drm to live under host1x Terje Bergstrom
2013-01-15 11:26     ` Terje Bergstrom
2013-01-15 11:26   ` [PATCHv5 6/8] gpu: host1x: Remove second host1x driver Terje Bergstrom
2013-01-15 11:26     ` Terje Bergstrom
2013-01-15 11:26   ` [PATCHv5 7/8] ARM: tegra: Add board data and 2D clocks Terje Bergstrom
2013-01-15 11:26     ` Terje Bergstrom
     [not found]     ` <1358249182-17486-8-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-15 18:44       ` Stephen Warren
2013-01-15 18:44         ` Stephen Warren
     [not found]         ` <50F5A3A6.7000801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-16  6:09           ` Terje Bergström
2013-01-16  6:09             ` Terje Bergström
2013-01-16  8:10           ` Terje Bergström
2013-01-16  8:10             ` Terje Bergström
2013-01-16 17:25             ` Stephen Warren
2013-01-15 11:33   ` Thierry Reding [this message]
2013-01-15 11:33     ` [PATCHv5 0/8] Support for Tegra 2D hardware Thierry Reding
2013-01-15 11:26 ` [PATCHv5 8/8] drm: tegra: Add gr2d device Terje Bergstrom
2013-01-15 11:26   ` Terje Bergstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130115113347.GC18119@avionic-0098.adnet.avionic-design.de \
    --to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.