All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: grant.likely@secretlab.ca, b-cousson@ti.com,
	rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk,
	balbi@ti.com, tony@atomide.com,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] usb: musb: add driver for control module
Date: Tue, 15 Jan 2013 13:41:08 +0000	[thread overview]
Message-ID: <201301151341.08297.arnd@arndb.de> (raw)
In-Reply-To: <1358239378-10030-1-git-send-email-kishon@ti.com>

On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
> 
> Writing to control module registers for doing the above task which was
> previously done in omap glue and in omap-usb2 phy is removed.
> 
> Also added the dt data to get MUSB working in OMAP platforms.
> This series has patches for both drivers and ARCH folders, so If it has to
> be split I'll do it.
> 

The series looks good to me, I just had a minor comment on one patch.

One a somewhat related topic, I wonder whether there are any plans
on your side to change this driver to support multiple bus glues
to be built for one kernel image. With a multiplatform kernel, we
may need all of TUSB6010/OMAP2PLUS/DSPS/UX500 for instance.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/7] usb: musb: add driver for control module
Date: Tue, 15 Jan 2013 13:41:08 +0000	[thread overview]
Message-ID: <201301151341.08297.arnd@arndb.de> (raw)
In-Reply-To: <1358239378-10030-1-git-send-email-kishon@ti.com>

On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
> 
> Writing to control module registers for doing the above task which was
> previously done in omap glue and in omap-usb2 phy is removed.
> 
> Also added the dt data to get MUSB working in OMAP platforms.
> This series has patches for both drivers and ARCH folders, so If it has to
> be split I'll do it.
> 

The series looks good to me, I just had a minor comment on one patch.

One a somewhat related topic, I wonder whether there are any plans
on your side to change this driver to support multiple bus glues
to be built for one kernel image. With a multiplatform kernel, we
may need all of TUSB6010/OMAP2PLUS/DSPS/UX500 for instance.

	Arnd

  parent reply	other threads:[~2013-01-15 13:41 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  8:42 [RFC PATCH 0/7] usb: musb: add driver for control module Kishon Vijay Abraham I
2013-01-15  8:42 ` Kishon Vijay Abraham I
2013-01-15  8:42 ` Kishon Vijay Abraham I
2013-01-15  8:42 ` [RFC PATCH 1/7] drivers: usb: phy: add a new driver for usb part of " Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
     [not found]   ` <1358239378-10030-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-01-15 13:36     ` Arnd Bergmann
2013-01-15 13:36       ` Arnd Bergmann
2013-01-15 13:36       ` Arnd Bergmann
2013-01-15 14:24       ` kishon
2013-01-15 14:24         ` kishon
2013-01-15 14:24         ` kishon
2013-01-15 14:46         ` Arnd Bergmann
2013-01-15 14:46           ` Arnd Bergmann
2013-01-15  8:42 ` [RFC PATCH 2/7] ARM: OMAP: devices: create device " Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
2013-01-15 12:53   ` Sergei Shtylyov
2013-01-15 12:53     ` Sergei Shtylyov
2013-01-15 14:26     ` kishon
2013-01-15 14:26       ` kishon
2013-01-15 14:26       ` kishon
2013-01-17 16:43       ` Sergei Shtylyov
2013-01-17 16:43         ` Sergei Shtylyov
2013-01-15  8:42 ` [RFC PATCH 4/7] drivers: usb: start using the control module driver Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
     [not found] ` <1358239378-10030-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-01-15  8:42   ` [RFC PATCH 3/7] ARM: OMAP2: MUSB: Specify omap4 has mailbox Kishon Vijay Abraham I
2013-01-15  8:42     ` Kishon Vijay Abraham I
2013-01-15  8:42     ` Kishon Vijay Abraham I
2013-01-15  8:42   ` [RFC PATCH 5/7] ARM: dts: omap: Add usb_otg and glue data Kishon Vijay Abraham I
2013-01-15  8:42     ` Kishon Vijay Abraham I
2013-01-15  8:42     ` Kishon Vijay Abraham I
2013-01-15  8:42   ` [RFC PATCH 7/7] ARM: dts: omap: Add omap control usb data Kishon Vijay Abraham I
2013-01-15  8:42     ` Kishon Vijay Abraham I
2013-01-15  8:42     ` Kishon Vijay Abraham I
2013-01-15  8:42 ` [RFC PATCH 6/7] ARM: dts: omap: Add omap-usb2 dt data Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
2013-01-15  8:42   ` Kishon Vijay Abraham I
2013-01-15 13:41 ` Arnd Bergmann [this message]
2013-01-15 13:41   ` [RFC PATCH 0/7] usb: musb: add driver for control module Arnd Bergmann
     [not found]   ` <201301151341.08297.arnd-r2nGTMty4D4@public.gmane.org>
2013-01-15 14:39     ` kishon
2013-01-15 14:39       ` kishon
2013-01-15 14:39       ` kishon
2013-01-15 15:04       ` Felipe Balbi
2013-01-15 15:04         ` Felipe Balbi
2013-01-15 15:04         ` Felipe Balbi
2013-01-15 16:06         ` B, Ravi
2013-01-15 16:06           ` B, Ravi
2013-01-16  6:01           ` kishon
2013-01-16  6:01             ` kishon
2013-01-16  7:13             ` Felipe Balbi
2013-01-16  7:13               ` Felipe Balbi
2013-01-18 11:47 ` Felipe Balbi
2013-01-18 11:47   ` Felipe Balbi
2013-01-18 11:47   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301151341.08297.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.