From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] module: potential deadlock in error path
Date: Fri, 18 Jan 2013 07:43:09 +0000 [thread overview]
Message-ID: <20130118074309.GB31793@elgon.mountain> (raw)
We take the lock twice if we hit this goto.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/module.c b/kernel/module.c
index d25e359..2eefa7d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3239,8 +3239,10 @@ again:
mutex_lock(&module_mutex);
/* Find duplicate symbols (must be called under lock). */
err = verify_export_symbols(mod);
- if (err < 0)
+ if (err < 0) {
+ mutex_unlock(&module_mutex);
goto ddebug_cleanup;
+ }
/* This relies on module_mutex for list integrity. */
module_bug_finalize(info->hdr, info->sechdrs, mod);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] module: potential deadlock in error path
Date: Fri, 18 Jan 2013 10:43:09 +0300 [thread overview]
Message-ID: <20130118074309.GB31793@elgon.mountain> (raw)
We take the lock twice if we hit this goto.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/module.c b/kernel/module.c
index d25e359..2eefa7d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3239,8 +3239,10 @@ again:
mutex_lock(&module_mutex);
/* Find duplicate symbols (must be called under lock). */
err = verify_export_symbols(mod);
- if (err < 0)
+ if (err < 0) {
+ mutex_unlock(&module_mutex);
goto ddebug_cleanup;
+ }
/* This relies on module_mutex for list integrity. */
module_bug_finalize(info->hdr, info->sechdrs, mod);
next reply other threads:[~2013-01-18 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 7:43 Dan Carpenter [this message]
2013-01-18 7:43 ` [patch] module: potential deadlock in error path Dan Carpenter
2013-01-21 1:20 ` Rusty Russell
2013-01-21 1:32 ` Rusty Russell
2013-01-21 1:56 ` Linus Torvalds
2013-01-21 1:56 ` Linus Torvalds
2013-01-21 3:52 ` Rusty Russell
2013-01-21 3:56 ` Rusty Russell
2013-01-21 4:37 ` Linus Torvalds
2013-01-21 4:37 ` Linus Torvalds
2013-01-21 8:58 ` Dan Carpenter
2013-01-21 8:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118074309.GB31793@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.