From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Murray <Andrew.Murray@arm.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
Arnd Bergmann <arnd@arndb.de>,
Stephen Warren <swarren@wwwdotorg.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH RFC 2/2] Improve bios32 support for DT PCI host bridge controllers
Date: Fri, 18 Jan 2013 11:43:40 +0000 [thread overview]
Message-ID: <20130118114340.GD23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130118114019.GA9034@arm.com>
On Fri, Jan 18, 2013 at 11:40:19AM +0000, Andrew Murray wrote:
> static void __init pcibios_init_hw(struct hw_pci *hw, struct list_head *head)
> {
> struct pci_sys_data *sys = NULL;
> + static int busnr;
> int ret;
> - int nr, busnr;
> -
> - for (nr = busnr = 0; nr < hw->nr_controllers; nr++) {
> + int nr;
> + for (nr = 0; nr < hw->nr_controllers; nr++) {
Please try to retain the originally formatting. There should be a blank
line between "int nr;" and "for...".
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Andrew Murray <Andrew.Murray-5wv7dgnIgG8@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH RFC 2/2] Improve bios32 support for DT PCI host bridge controllers
Date: Fri, 18 Jan 2013 11:43:40 +0000 [thread overview]
Message-ID: <20130118114340.GD23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130118114019.GA9034-5wv7dgnIgG8@public.gmane.org>
On Fri, Jan 18, 2013 at 11:40:19AM +0000, Andrew Murray wrote:
> static void __init pcibios_init_hw(struct hw_pci *hw, struct list_head *head)
> {
> struct pci_sys_data *sys = NULL;
> + static int busnr;
> int ret;
> - int nr, busnr;
> -
> - for (nr = busnr = 0; nr < hw->nr_controllers; nr++) {
> + int nr;
> + for (nr = 0; nr < hw->nr_controllers; nr++) {
Please try to retain the originally formatting. There should be a blank
line between "int nr;" and "for...".
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/2] Improve bios32 support for DT PCI host bridge controllers
Date: Fri, 18 Jan 2013 11:43:40 +0000 [thread overview]
Message-ID: <20130118114340.GD23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130118114019.GA9034@arm.com>
On Fri, Jan 18, 2013 at 11:40:19AM +0000, Andrew Murray wrote:
> static void __init pcibios_init_hw(struct hw_pci *hw, struct list_head *head)
> {
> struct pci_sys_data *sys = NULL;
> + static int busnr;
> int ret;
> - int nr, busnr;
> -
> - for (nr = busnr = 0; nr < hw->nr_controllers; nr++) {
> + int nr;
> + for (nr = 0; nr < hw->nr_controllers; nr++) {
Please try to retain the originally formatting. There should be a blank
line between "int nr;" and "for...".
next prev parent reply other threads:[~2013-01-18 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 11:40 [PATCH RFC 2/2] Improve bios32 support for DT PCI host bridge controllers Andrew Murray
2013-01-18 11:40 ` Andrew Murray
2013-01-18 11:40 ` Andrew Murray
2013-01-18 11:43 ` Russell King - ARM Linux [this message]
2013-01-18 11:43 ` Russell King - ARM Linux
2013-01-18 11:43 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118114340.GD23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Andrew.Murray@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.