From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT
Date: Fri, 18 Jan 2013 13:39:01 -0800 [thread overview]
Message-ID: <20130118133901.b445b348.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358501604-6797-1-git-send-email-mhocko@suse.cz>
On Fri, 18 Jan 2013 10:33:24 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> CONFIG_PARAVIRT defines set_pmd_at only for CONFIG_TRANSPARENT_HUGEPAGE
> which leads to the following compile errors when randconfig selected
> CONFIG_NUMA_BALANCING && CONFIG_PARAVIRT && !CONFIG_TRANSPARENT_HUGEPAGE:
>
> mm/mprotect.c: In function ___change_pmd_protnuma___:
> mm/mprotect.c:120: error: implicit declaration of function ___set_pmd_at___
>
> mm/memory.c: In function ___do_pmd_numa_page___:
> mm/memory.c:3529: error: implicit declaration of function ___set_pmd_at___
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
> arch/x86/include/asm/paravirt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
> index a0facf3..f551e89 100644
> --- a/arch/x86/include/asm/paravirt.h
> +++ b/arch/x86/include/asm/paravirt.h
> @@ -528,7 +528,7 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte);
> }
>
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_NUMA_BALANCING)
> static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
> pmd_t *pmdp, pmd_t pmd)
> {
Confused - there is no "#ifdef CONFIG_TRANSPARENT_HUGEPAGE" in there in
any kernel version I can think of.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT
Date: Fri, 18 Jan 2013 13:39:01 -0800 [thread overview]
Message-ID: <20130118133901.b445b348.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358501604-6797-1-git-send-email-mhocko@suse.cz>
On Fri, 18 Jan 2013 10:33:24 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> CONFIG_PARAVIRT defines set_pmd_at only for CONFIG_TRANSPARENT_HUGEPAGE
> which leads to the following compile errors when randconfig selected
> CONFIG_NUMA_BALANCING && CONFIG_PARAVIRT && !CONFIG_TRANSPARENT_HUGEPAGE:
>
> mm/mprotect.c: In function ___change_pmd_protnuma___:
> mm/mprotect.c:120: error: implicit declaration of function ___set_pmd_at___
>
> mm/memory.c: In function ___do_pmd_numa_page___:
> mm/memory.c:3529: error: implicit declaration of function ___set_pmd_at___
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
> arch/x86/include/asm/paravirt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
> index a0facf3..f551e89 100644
> --- a/arch/x86/include/asm/paravirt.h
> +++ b/arch/x86/include/asm/paravirt.h
> @@ -528,7 +528,7 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte);
> }
>
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_NUMA_BALANCING)
> static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
> pmd_t *pmdp, pmd_t pmd)
> {
Confused - there is no "#ifdef CONFIG_TRANSPARENT_HUGEPAGE" in there in
any kernel version I can think of.
next prev parent reply other threads:[~2013-01-18 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 9:33 [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT Michal Hocko
2013-01-18 9:33 ` Michal Hocko
2013-01-18 21:39 ` Andrew Morton [this message]
2013-01-18 21:39 ` Andrew Morton
2013-01-19 9:36 ` Michal Hocko
2013-01-19 9:36 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118133901.b445b348.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.