All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] agp/intel: Add gma_bus_addr
Date: Fri, 18 Jan 2013 19:22:01 -0800	[thread overview]
Message-ID: <20130119032201.GA1479@lundgren.kumite> (raw)
In-Reply-To: <20130118211824.GX8347@phenom.ffwll.local>

On Fri, Jan 18, 2013 at 10:18:24PM +0100, Daniel Vetter wrote:
> On Fri, Jan 18, 2013 at 12:30:34PM -0800, Ben Widawsky wrote:
> > It is no longer used in the i915 code, so isolate it from the shared
> > struct.
> > 
> > This was originally part of:
> > commit 0e275518f325418d559c05327775bff894b237f7
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Mon Jan 14 13:35:33 2013 -0800
> > 
> >     agp/intel: decouple more of the agp-i915 sharing
> > 
> >     Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> >     Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > 
> > That commit had some other hunks which can't be used due to issues
> > Daniel found in previous commits.
> > 
> > Recommend to squash this in to:
> > commit 42389dbda7398dac0ceadef327d51dc5509f9399
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Fri Jan 11 13:50:28 2013 -0800
> > 
> >     drm/i915: Remove use on gma_bus_addr on gen6+
> > 
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> All slurped into dinq, thanks for the patches.
> -Daniel

It seems the accidentally dropped hunk you caught is indeed a problem on
my machine. I've submitted a patch to revert it.

Sorry.


-- 
Ben Widawsky, Intel Open Source Technology Center

      reply	other threads:[~2013-01-19  3:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 23:04 [drm-intel:drm-intel-next-queued 17/20] drivers/gpu/drm/i915/i915_debugfs.c:263:6: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'long unsigned int' kbuild test robot
2013-01-18 20:27 ` [PATCH 1/5] drm/i915: Fix %z from last patch Ben Widawsky
2013-01-18 20:30   ` [PATCH 2/5] drm/i915: Cut out the infamous ILK w/a from AGP layer Ben Widawsky
2013-01-18 20:30     ` [PATCH 3/5] drm/i915: Remove scratch page from shared Ben Widawsky
2013-01-18 20:30     ` [PATCH 4/5] drm/i915: Needs_dmar, not Ben Widawsky
2013-01-18 20:30     ` [PATCH 5/5] agp/intel: Add gma_bus_addr Ben Widawsky
2013-01-18 21:18       ` Daniel Vetter
2013-01-19  3:22         ` Ben Widawsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130119032201.GA1479@lundgren.kumite \
    --to=ben@bwidawsk.net \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.