From: Vinod Koul <vinod.koul@intel.com>
To: Matt Porter <mporter@ti.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux OMAP List <linux-omap@vger.kernel.org>
Subject: Re: [RESEND][PATCH] dma: edma: fix slave config dependency on direction
Date: Sun, 20 Jan 2013 04:05:15 -0800 [thread overview]
Message-ID: <20130120120515.GB23398@intel.com> (raw)
In-Reply-To: <1357843264-27045-1-git-send-email-mporter@ti.com>
On Thu, Jan 10, 2013 at 01:41:04PM -0500, Matt Porter wrote:
> The edma_slave_config() implementation depends on the
> direction field such that it will not properly configure
> a slave channel when called without direction set.
>
> This fixes the implementation so that the slave config
> is copied as is and prep_slave_sg() handles the
> direction dependent handling. spi-omap2-mcspi and
> omap_hsmmc both expose this bug as they configure the
> slave channel config from a common path with an unconfigured
> direction field.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
Applied, Thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][PATCH] dma: edma: fix slave config dependency on direction
Date: Sun, 20 Jan 2013 04:05:15 -0800 [thread overview]
Message-ID: <20130120120515.GB23398@intel.com> (raw)
In-Reply-To: <1357843264-27045-1-git-send-email-mporter@ti.com>
On Thu, Jan 10, 2013 at 01:41:04PM -0500, Matt Porter wrote:
> The edma_slave_config() implementation depends on the
> direction field such that it will not properly configure
> a slave channel when called without direction set.
>
> This fixes the implementation so that the slave config
> is copied as is and prep_slave_sg() handles the
> direction dependent handling. spi-omap2-mcspi and
> omap_hsmmc both expose this bug as they configure the
> slave channel config from a common path with an unconfigured
> direction field.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
Applied, Thanks
--
~Vinod
next prev parent reply other threads:[~2013-01-20 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 18:41 [RESEND][PATCH] dma: edma: fix slave config dependency on direction Matt Porter
2013-01-10 18:41 ` Matt Porter
2013-01-20 12:05 ` Vinod Koul [this message]
2013-01-20 12:05 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130120120515.GB23398@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.