Re: [PATCH 1/2] iio: mxs: Add MX23 support into the IIO driver

[Marek Vasut <marex@denx.de>]

Dear Micha=C5=82 Miros=C5=82aw,

> 2013/1/21 Marek Vasut <marex@denx.de>:
> > Dear Micha=C5=82 Miros=C5=82aw,
> >=20
> >> 2013/1/21 Marek Vasut <marex@denx.de>:
> >> > This patch adds support for i.MX23 into the LRADC driver. The LRADC
> >> > block on MX23 is not much different from the one on MX28, thus this
> >> > is only a few changes fixing the parts that are specific to MX23.
> >>=20
> >> [...]
> >>=20
> >> > +struct mxs_lradc_of_config {
> >> > +       const int               irq_count;
> >> > +       const char * const      *irq_name;
> >> > +};
> >> > +
> >> > +static const struct mxs_lradc_of_config const mxs_lradc_of_config[]=
 =3D
> >> > { +       [IMX23_LRADC] =3D {
> >> > +               .irq_count      =3D ARRAY_SIZE(mx23_lradc_irq_names),
> >> > +               .irq_name       =3D mx23_lradc_irq_names,
> >> > +       },
> >> > +       [IMX28_LRADC] =3D {
> >> > +               .irq_count      =3D ARRAY_SIZE(mx28_lradc_irq_names),
> >> > +               .irq_name       =3D mx28_lradc_irq_names,
> >> > +       },
> >> > +};
> >> > +
> >> >=20
> >> >  enum mxs_lradc_ts {
> >> > =20
> >> >         MXS_LRADC_TOUCHSCREEN_NONE =3D 0,
> >> >         MXS_LRADC_TOUCHSCREEN_4WIRE,
> >> >=20
> >> > @@ -857,8 +890,19 @@ static void mxs_lradc_hw_stop(struct mxs_lradc
> >> > *lradc)
> >> >=20
> >> >                 writel(0, lradc->base + LRADC_DELAY(i));
> >> > =20
> >> >  }
> >> >=20
> >> > +static const struct of_device_id mxs_lradc_dt_ids[] =3D {
> >> > +       { .compatible =3D "fsl,imx23-lradc", .data =3D (void
> >> > *)IMX23_LRADC, }, +       { .compatible =3D "fsl,imx28-lradc", .data=
 =3D
> >> > (void
> >> > *)IMX28_LRADC, }, +       { /* sentinel */ }
> >> > +};
> >> > +MODULE_DEVICE_TABLE(of, mxs_lradc_dt_ids);
> >> > +
> >>=20
> >> Why not s/(void \*)\(IMX.._LRADC\)/\&mxs_lradc_of_config[\1]/ ?
> >=20
> > Check the register layout, it differs between MX23 and MX28, that's one
> > reason, since were we to access differently placed registers, we can do
> > it easily as in the SSP/I2C drivers.
> >=20
> > Moreover, there are some features on the MX28 that are not on the MX23
> > (like voltage treshold triggers and touchbuttons), with this setup, we
> > can easily check what we're running at at runtime and determine to
> > disallow these.
> >=20
> > From my point of view, using the number (IMX23_LRADC / IMX28_LRADC) is
> > much more convenient in the long run.
>=20
> I'm asking, because you don't use this number anywhere other than in
> mxs_lradc_probe()
> and there only to dereference the irq-names table. After that the
> structure and number
> are forgotten.

Certainly, so far it's used only this way. But please see my argument about=
=20
register layout, that's why I went down this road of abstraction.

> Sure, it's just an insn or two, so no strong opinion here --- just curiou=
s.

I tried to put it down above ;-)

> Best Regards,
> Micha=C5=82 Miros=C5=82aw

Best regards,
Marek Vasut