From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Anton Blanchard <anton@au1.ibm.com>,
paulus@samba.org, linux-kernel@vger.kernel.org,
acme@ghostprotocols.net
Subject: Re: [PATCH] perf: Fix compile warnings in tests/attr.c
Date: Tue, 22 Jan 2013 14:57:26 +0100 [thread overview]
Message-ID: <20130122135726.GD1037@krava.brq.redhat.com> (raw)
In-Reply-To: <20130121213823.GA4774@us.ibm.com>
On Mon, Jan 21, 2013 at 01:38:23PM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jolsa@redhat.com] wrote:
> | On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote:
SNIP
> __u64 is 'unsigned long long' on x86 and PRIu64 is 'llu' which is fine.
>
> __u64 is 'unsigned long' on Power and PRIu64 is 'lu' which is again fine.
>
> But __u64 is 'unsigned long long' on x86_64, but PRIu64 is '%lu' bc __WORDSIZE
> is 64.
>
> On x86_64, shouldn't __u64, be defined as 'unsigned long' rather than
> 'unsigned long long' - ie include 'int-l64.h' rather than 'int-ll64.h' ?
hum, not sure ;-) will try to find some time to look on that
>
> BTW, does 'perf' with my patch compile, (with warnings) for you on x86_64
> with 'WERROR=0 make' ?
this one passes with warnings
jirka
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: acme@ghostprotocols.net, Anton Blanchard <anton@au1.ibm.com>,
paulus@samba.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] perf: Fix compile warnings in tests/attr.c
Date: Tue, 22 Jan 2013 14:57:26 +0100 [thread overview]
Message-ID: <20130122135726.GD1037@krava.brq.redhat.com> (raw)
In-Reply-To: <20130121213823.GA4774@us.ibm.com>
On Mon, Jan 21, 2013 at 01:38:23PM -0800, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jolsa@redhat.com] wrote:
> | On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote:
SNIP
> __u64 is 'unsigned long long' on x86 and PRIu64 is 'llu' which is fine.
>
> __u64 is 'unsigned long' on Power and PRIu64 is 'lu' which is again fine.
>
> But __u64 is 'unsigned long long' on x86_64, but PRIu64 is '%lu' bc __WORDSIZE
> is 64.
>
> On x86_64, shouldn't __u64, be defined as 'unsigned long' rather than
> 'unsigned long long' - ie include 'int-l64.h' rather than 'int-ll64.h' ?
hum, not sure ;-) will try to find some time to look on that
>
> BTW, does 'perf' with my patch compile, (with warnings) for you on x86_64
> with 'WERROR=0 make' ?
this one passes with warnings
jirka
next prev parent reply other threads:[~2013-01-22 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 1:30 [PATCH] perf: Fix compile warnings in tests/attr.c Sukadev Bhattiprolu
2013-01-19 1:30 ` Sukadev Bhattiprolu
2013-01-21 13:59 ` Jiri Olsa
2013-01-21 13:59 ` Jiri Olsa
2013-01-21 21:38 ` Sukadev Bhattiprolu
2013-01-21 21:38 ` Sukadev Bhattiprolu
2013-01-22 13:57 ` Jiri Olsa [this message]
2013-01-22 13:57 ` Jiri Olsa
2013-01-22 23:45 ` Michael Ellerman
2013-01-22 23:45 ` Michael Ellerman
2013-01-23 18:57 ` Sukadev Bhattiprolu
2013-01-23 18:57 ` Sukadev Bhattiprolu
2013-01-24 2:42 ` Michael Ellerman
2013-01-24 2:42 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122135726.GD1037@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=anton@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.