From: Minchan Kim <minchan@kernel.org>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
jmarchan@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH v5 1/4] zram: Fix deadlock bug in partial write
Date: Wed, 23 Jan 2013 09:06:48 +0900 [thread overview]
Message-ID: <20130123000648.GA2723@blaptop> (raw)
In-Reply-To: <CAPkvG_f2mDr2p=ypqcikeNMRoE3tK1-kDjLWyz6bb9yQUpGgZQ@mail.gmail.com>
Hi Nitin,
On Tue, Jan 22, 2013 at 03:58:10PM -0800, Nitin Gupta wrote:
> On Tue, Jan 22, 2013 at 3:52 PM, Minchan Kim <minchan@kernel.org> wrote:
> > Now zram allocates new page with GFP_KERNEL in zram I/O path
> > if IO is partial. Unfortunately, It may cuase deadlock with
> > reclaim path so this patch solves the problem.
> >
> > Cc: Jerome Marchand <jmarchan@redhat.com>
> > Cc: stable@vger.kernel.org
> > Acked-by: Nitin Gupta <ngupta@vflare.org>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> > drivers/staging/zram/zram_drv.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Changelog for v4 vs v5?
It's just adding your Acked-by in whole series.
I thought it's minor.
Thanks for the review, Nitin.
>
> Thanks,
> Nitin
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
jmarchan@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH v5 1/4] zram: Fix deadlock bug in partial write
Date: Wed, 23 Jan 2013 09:06:48 +0900 [thread overview]
Message-ID: <20130123000648.GA2723@blaptop> (raw)
In-Reply-To: <CAPkvG_f2mDr2p=ypqcikeNMRoE3tK1-kDjLWyz6bb9yQUpGgZQ@mail.gmail.com>
Hi Nitin,
On Tue, Jan 22, 2013 at 03:58:10PM -0800, Nitin Gupta wrote:
> On Tue, Jan 22, 2013 at 3:52 PM, Minchan Kim <minchan@kernel.org> wrote:
> > Now zram allocates new page with GFP_KERNEL in zram I/O path
> > if IO is partial. Unfortunately, It may cuase deadlock with
> > reclaim path so this patch solves the problem.
> >
> > Cc: Jerome Marchand <jmarchan@redhat.com>
> > Cc: stable@vger.kernel.org
> > Acked-by: Nitin Gupta <ngupta@vflare.org>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> > drivers/staging/zram/zram_drv.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Changelog for v4 vs v5?
It's just adding your Acked-by in whole series.
I thought it's minor.
Thanks for the review, Nitin.
>
> Thanks,
> Nitin
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2013-01-23 0:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 23:52 [PATCH v5 1/4] zram: Fix deadlock bug in partial write Minchan Kim
2013-01-22 23:52 ` Minchan Kim
2013-01-22 23:52 ` [PATCH v5 2/4] zram: force disksize setting before using zram Minchan Kim
2013-01-22 23:52 ` Minchan Kim
2013-01-22 23:52 ` [PATCH v5 3/4] zram: give up lazy initialization of zram metadata Minchan Kim
2013-01-22 23:52 ` Minchan Kim
2013-01-22 23:52 ` [PATCH v5 4/4] zram: get rid of lockdep warning Minchan Kim
2013-01-22 23:52 ` Minchan Kim
2013-01-22 23:58 ` [PATCH v5 1/4] zram: Fix deadlock bug in partial write Nitin Gupta
2013-01-22 23:58 ` Nitin Gupta
2013-01-23 0:06 ` Minchan Kim [this message]
2013-01-23 0:06 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123000648.GA2723@blaptop \
--to=minchan@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmarchan@redhat.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=penberg@cs.helsinki.fi \
--cc=sjenning@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.