From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"Nori, Sekhar" <nsekhar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob@landley.net" <rob@landley.net>,
"Girdwood, Liam" <lrg@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] ASoC: Davinci: machine: Add device tree binding
Date: Wed, 23 Jan 2013 23:48:12 +0800 [thread overview]
Message-ID: <20130123154804.GB4565@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EB50DCF@DBDE01.ent.ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]
On Wed, Jan 23, 2013 at 12:39:35PM +0000, Hebbar, Gururaja wrote:
> On Fri, Jan 04, 2013 at 17:56:12, Mark Brown wrote:
> > The CODEC driver biases should be changed over to be supplies, this
> > makes the above much more natural - the routing there is a hack for
> > older versions of ASoc. Otherwise this looks fine.
> ON TLV320AIC3x Codec, MIC Bias power on/off share the same register bits
> with Bias voltage output.
So you need to use an event to write the actual enable bit.
> SGTL5000 --> Single register for MIC BIAS enable & output impedance of MIC
> Bias. The driver uses SND_SOC_DAPM_POST_PMU & SND_SOC_DAPM_PRE_PMD macro to
> handle the MIC Bias enable & disable event.
This is the way these things should be handled.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH V2 2/2] ASoC: Davinci: machine: Add device tree binding
Date: Wed, 23 Jan 2013 23:48:12 +0800 [thread overview]
Message-ID: <20130123154804.GB4565@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EB50DCF@DBDE01.ent.ti.com>
On Wed, Jan 23, 2013 at 12:39:35PM +0000, Hebbar, Gururaja wrote:
> On Fri, Jan 04, 2013 at 17:56:12, Mark Brown wrote:
> > The CODEC driver biases should be changed over to be supplies, this
> > makes the above much more natural - the routing there is a hack for
> > older versions of ASoc. Otherwise this looks fine.
> ON TLV320AIC3x Codec, MIC Bias power on/off share the same register bits
> with Bias voltage output.
So you need to use an event to write the actual enable bit.
> SGTL5000 --> Single register for MIC BIAS enable & output impedance of MIC
> Bias. The driver uses SND_SOC_DAPM_POST_PMU & SND_SOC_DAPM_PRE_PMD macro to
> handle the MIC Bias enable & disable event.
This is the way these things should be handled.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130123/8e8582a0/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"Nori, Sekhar" <nsekhar@ti.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"rob@landley.net" <rob@landley.net>,
"Girdwood, Liam" <lrg@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH V2 2/2] ASoC: Davinci: machine: Add device tree binding
Date: Wed, 23 Jan 2013 23:48:12 +0800 [thread overview]
Message-ID: <20130123154804.GB4565@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EB50DCF@DBDE01.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Wed, Jan 23, 2013 at 12:39:35PM +0000, Hebbar, Gururaja wrote:
> On Fri, Jan 04, 2013 at 17:56:12, Mark Brown wrote:
> > The CODEC driver biases should be changed over to be supplies, this
> > makes the above much more natural - the routing there is a hack for
> > older versions of ASoc. Otherwise this looks fine.
> ON TLV320AIC3x Codec, MIC Bias power on/off share the same register bits
> with Bias voltage output.
So you need to use an event to write the actual enable bit.
> SGTL5000 --> Single register for MIC BIAS enable & output impedance of MIC
> Bias. The driver uses SND_SOC_DAPM_POST_PMU & SND_SOC_DAPM_PRE_PMD macro to
> handle the MIC Bias enable & disable event.
This is the way these things should be handled.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-23 15:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 9:54 [PATCH V2 0/2] ARM/ASoC: Davinci: Device Tree Update Hebbar Gururaja
2013-01-04 9:54 ` Hebbar Gururaja
2013-01-04 9:54 ` Hebbar Gururaja
2013-01-04 9:54 ` [PATCH V2 1/2] ASoC: davinci-mcasp: Add pinctrl support Hebbar Gururaja
2013-01-04 9:54 ` Hebbar Gururaja
2013-01-04 9:54 ` Hebbar Gururaja
2013-01-04 11:38 ` Mark Brown
2013-01-04 11:38 ` Mark Brown
2013-01-04 11:38 ` Mark Brown
[not found] ` <1357293277-25543-1-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2013-01-04 9:54 ` [PATCH V2 2/2] ASoC: Davinci: machine: Add device tree binding Hebbar Gururaja
2013-01-04 9:54 ` Hebbar Gururaja
2013-01-04 9:54 ` Hebbar Gururaja
2013-01-04 12:26 ` Mark Brown
2013-01-04 12:26 ` Mark Brown
2013-01-07 9:20 ` [alsa-devel] " Hebbar, Gururaja
2013-01-07 9:20 ` Hebbar, Gururaja
2013-01-07 14:27 ` Mark Brown
2013-01-07 14:27 ` Mark Brown
2013-01-23 12:39 ` Hebbar, Gururaja
2013-01-23 12:39 ` Hebbar, Gururaja
2013-01-23 15:48 ` Mark Brown [this message]
2013-01-23 15:48 ` Mark Brown
2013-01-23 15:48 ` Mark Brown
2013-01-24 9:33 ` Hebbar, Gururaja
2013-01-24 9:33 ` Hebbar, Gururaja
2013-01-24 10:02 ` Mark Brown
2013-01-24 10:02 ` Mark Brown
2013-01-24 10:06 ` Hebbar, Gururaja
2013-01-24 10:06 ` Hebbar, Gururaja
2013-01-24 10:13 ` Mark Brown
2013-01-24 10:13 ` [alsa-devel] " Mark Brown
2013-01-24 10:13 ` Mark Brown
2013-01-24 10:24 ` Hebbar, Gururaja
2013-01-24 10:24 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123154804.GB4565@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.