From: Steffen Klassert <steffen.klassert@secunet.com>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Tom St Denis <tstdenis@elliptictech.com>,
linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues
Date: Thu, 24 Jan 2013 10:43:37 +0100 [thread overview]
Message-ID: <20130124094337.GJ9147@secunet.com> (raw)
In-Reply-To: <20130123173510.14986sla4qsstz8k@www.dalek.fi>
On Wed, Jan 23, 2013 at 05:35:10PM +0200, Jussi Kivilinna wrote:
>
> Problem seems to be that PFKEYv2 does not quite work with IKEv2, and
> XFRM API should be used instead. There is new numbers assigned for
> IKEv2: https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xml#ikev2-parameters-7
>
> For new SADB_X_AALG_*, I'd think you should use value from "Reserved
> for private use" range. Maybe 250?
This would be an option, but we have just a few slots for private
algorithms.
>
> But maybe better solution might be to not make AES-CMAC (or other
> new algorithms) available throught PFKEY API at all, just XFRM?
>
It is probably the best to make new algorithms unavailable for pfkey
as long as they have no official ikev1 iana transform identifier.
But how to do that? Perhaps we can assign SADB_X_AALG_NOPFKEY to
the private value 255 and return -EINVAL if pfkey tries to register
such an algorithm. The netlink interface does not use these
identifiers, everything should work as expected. So it should be
possible to use these algoritms with iproute2 and the most modern
ike deamons.
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Tom St Denis <tstdenis@elliptictech.com>,
linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
David Miller <davem@davemloft.net>,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues
Date: Thu, 24 Jan 2013 10:43:37 +0100 [thread overview]
Message-ID: <20130124094337.GJ9147@secunet.com> (raw)
In-Reply-To: <20130123173510.14986sla4qsstz8k@www.dalek.fi>
On Wed, Jan 23, 2013 at 05:35:10PM +0200, Jussi Kivilinna wrote:
>
> Problem seems to be that PFKEYv2 does not quite work with IKEv2, and
> XFRM API should be used instead. There is new numbers assigned for
> IKEv2: https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xml#ikev2-parameters-7
>
> For new SADB_X_AALG_*, I'd think you should use value from "Reserved
> for private use" range. Maybe 250?
This would be an option, but we have just a few slots for private
algorithms.
>
> But maybe better solution might be to not make AES-CMAC (or other
> new algorithms) available throught PFKEY API at all, just XFRM?
>
It is probably the best to make new algorithms unavailable for pfkey
as long as they have no official ikev1 iana transform identifier.
But how to do that? Perhaps we can assign SADB_X_AALG_NOPFKEY to
the private value 255 and return -EINVAL if pfkey tries to register
such an algorithm. The netlink interface does not use these
identifiers, everything should work as expected. So it should be
possible to use these algoritms with iproute2 and the most modern
ike deamons.
next prev parent reply other threads:[~2013-01-24 9:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <537355069.94465.1358772395763.JavaMail.root@elliptictech.com>
2013-01-21 12:57 ` [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues Tom St Denis
2013-01-21 12:57 ` Tom St Denis
2013-01-21 16:35 ` David Dillow
2013-01-21 16:40 ` David Dillow
2013-01-23 7:41 ` Steffen Klassert
2013-01-23 7:41 ` Steffen Klassert
2013-01-23 14:36 ` Jussi Kivilinna
2013-01-23 14:36 ` Jussi Kivilinna
2013-01-23 14:46 ` Tom St Denis
2013-01-23 14:46 ` Tom St Denis
2013-01-23 15:35 ` Jussi Kivilinna
2013-01-23 15:35 ` Jussi Kivilinna
2013-01-23 15:46 ` Tom St Denis
2013-01-23 15:46 ` Tom St Denis
2013-01-23 16:16 ` YOSHIFUJI Hideaki
2013-01-23 16:16 ` YOSHIFUJI Hideaki
2013-01-23 16:25 ` YOSHIFUJI Hideaki
2013-01-23 16:25 ` YOSHIFUJI Hideaki
2013-01-24 8:45 ` Jussi Kivilinna
2013-01-24 8:45 ` Jussi Kivilinna
2013-01-24 9:43 ` Steffen Klassert [this message]
2013-01-24 9:43 ` Steffen Klassert
2013-01-24 11:25 ` Jussi Kivilinna
2013-01-24 11:25 ` Jussi Kivilinna
2013-01-24 12:32 ` Steffen Klassert
2013-01-24 12:32 ` Steffen Klassert
2013-01-24 12:37 ` Tom St Denis
2013-01-24 12:37 ` Tom St Denis
2013-01-24 12:52 ` Steffen Klassert
2013-01-24 12:52 ` Steffen Klassert
2013-01-24 13:00 ` Tom St Denis
2013-01-24 13:00 ` Tom St Denis
2013-01-29 9:33 ` Steffen Klassert
2013-01-29 9:33 ` Steffen Klassert
2013-01-31 9:35 ` Jussi Kivilinna
2013-01-31 9:35 ` Jussi Kivilinna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124094337.GJ9147@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tstdenis@elliptictech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.