All of lore.kernel.org
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] ARM: at91/at91_dt_defconfig: remove memory specification to cmdline
Date: Thu, 24 Jan 2013 11:44:07 +0100	[thread overview]
Message-ID: <20130124104407.GL7360@game.jcrosoft.org> (raw)
In-Reply-To: <5100F4ED.9000004@atmel.com>

On 09:46 Thu 24 Jan     , Nicolas Ferre wrote:
> On 01/23/2013 11:20 AM, Jean-Christophe PLAGNIOL-VILLARD :
> > On 10:48 Wed 23 Jan     , Nicolas Ferre wrote:
> >> No need for this cmdline option as we are using DT.
> >> Moreover this defconfig is targeted to multiple SoC/boards: this option
> >> was nonsense.
> > just keep the console the rest is a nonsense too
> > 
> > as on 9g45 the initrd will be at 0x7xxxxxxx
> 
> Understood, but I prefer to keep a "root" option at least, so I keep it
> like this.
> 
> > the console too but as the patch serie to support via DT is not yet mainline
> > we can keep it
> 
> Ok for this.

I check and the default commande line in the defconfig is a nonsense now

as we will provide a default one via dt anyway

and the root option will not work on 9g45

so it's better to simply drop it

Best Regards,
J.
> 
> > 
> > Best Regards,
> > J.
> >>
> >> Reported-by: Josh Wu <josh.wu@atmel.com>
> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >> ---
> >>  arch/arm/configs/at91_dt_defconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
> >> index b175577..a353ff6 100644
> >> --- a/arch/arm/configs/at91_dt_defconfig
> >> +++ b/arch/arm/configs/at91_dt_defconfig
> >> @@ -31,7 +31,7 @@ CONFIG_ZBOOT_ROM_TEXT=0x0
> >>  CONFIG_ZBOOT_ROM_BSS=0x0
> >>  CONFIG_ARM_APPENDED_DTB=y
> >>  CONFIG_ARM_ATAG_DTB_COMPAT=y
> >> -CONFIG_CMDLINE="mem=128M console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw"
> >> +CONFIG_CMDLINE="console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw"
> >>  CONFIG_KEXEC=y
> >>  CONFIG_AUTO_ZRELADDR=y
> >>  # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
> >> -- 
> >> 1.8.0
> >>
> > 
> > 
> 
> 
> -- 
> Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	richard.genoud@gmail.com, linux-arm@overkiz.com,
	manabian@gmail.com, dgilbert@interlog.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Josh Wu <josh.wu@atmel.com>,
	Bo Shen <voice.shen@atmel.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [PATCH 7/9] ARM: at91/at91_dt_defconfig: remove memory specification to cmdline
Date: Thu, 24 Jan 2013 11:44:07 +0100	[thread overview]
Message-ID: <20130124104407.GL7360@game.jcrosoft.org> (raw)
In-Reply-To: <5100F4ED.9000004@atmel.com>

On 09:46 Thu 24 Jan     , Nicolas Ferre wrote:
> On 01/23/2013 11:20 AM, Jean-Christophe PLAGNIOL-VILLARD :
> > On 10:48 Wed 23 Jan     , Nicolas Ferre wrote:
> >> No need for this cmdline option as we are using DT.
> >> Moreover this defconfig is targeted to multiple SoC/boards: this option
> >> was nonsense.
> > just keep the console the rest is a nonsense too
> > 
> > as on 9g45 the initrd will be at 0x7xxxxxxx
> 
> Understood, but I prefer to keep a "root" option at least, so I keep it
> like this.
> 
> > the console too but as the patch serie to support via DT is not yet mainline
> > we can keep it
> 
> Ok for this.

I check and the default commande line in the defconfig is a nonsense now

as we will provide a default one via dt anyway

and the root option will not work on 9g45

so it's better to simply drop it

Best Regards,
J.
> 
> > 
> > Best Regards,
> > J.
> >>
> >> Reported-by: Josh Wu <josh.wu@atmel.com>
> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >> ---
> >>  arch/arm/configs/at91_dt_defconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
> >> index b175577..a353ff6 100644
> >> --- a/arch/arm/configs/at91_dt_defconfig
> >> +++ b/arch/arm/configs/at91_dt_defconfig
> >> @@ -31,7 +31,7 @@ CONFIG_ZBOOT_ROM_TEXT=0x0
> >>  CONFIG_ZBOOT_ROM_BSS=0x0
> >>  CONFIG_ARM_APPENDED_DTB=y
> >>  CONFIG_ARM_ATAG_DTB_COMPAT=y
> >> -CONFIG_CMDLINE="mem=128M console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw"
> >> +CONFIG_CMDLINE="console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw"
> >>  CONFIG_KEXEC=y
> >>  CONFIG_AUTO_ZRELADDR=y
> >>  # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
> >> -- 
> >> 1.8.0
> >>
> > 
> > 
> 
> 
> -- 
> Nicolas Ferre

  reply	other threads:[~2013-01-24 10:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23  9:48 [PATCH 0/9 v2] at91: some fixes for 3.8-rc5 Nicolas Ferre
2013-01-23  9:48 ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 1/9] ARM: at91/at91-pinctrl documentation: fix typo and add some details Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 2/9] ARM: at91/at91sam9x5 DTS: correct wrong PIO BANK values on u(s)arts Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 3/9] ARM: at91/at91sam9x5 DTS: add SCK USART pins Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 4/9] ARM: at91: fix gpios on i2c-gpio for RM9200 DT Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 5/9] ARM: at91: rm9200: remake the BGA as default version Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 6/9] ARM: at91/dts: add macb mii pinctrl config for kizbox Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 7/9] ARM: at91/at91_dt_defconfig: remove memory specification to cmdline Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23 10:20   ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-23 10:20     ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-23 11:42     ` Nicolas Ferre
2013-01-23 11:42       ` Nicolas Ferre
2013-01-23 12:42       ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-23 12:42         ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-24  8:46     ` Nicolas Ferre
2013-01-24  8:46       ` Nicolas Ferre
2013-01-24 10:44       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-01-24 10:44         ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-23  9:48 ` [PATCH 8/9] ARM: at91/at91_dt_defconfig: add at91sam9n12 SoC to DT defconfig Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre
2013-01-23  9:48 ` [PATCH 9/9] ARM: at91/dts: correct comment in at91sam9x5.dtsi for mii Nicolas Ferre
2013-01-23  9:48   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124104407.GL7360@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.