From: Wolfram Sang <w.sang@pengutronix.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-i2c@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
naveenkrishna.ch@gmail.com, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org, olofj@chromium.org
Subject: Re: [PATCH] i2c: samsung: resume race fix
Date: Thu, 24 Jan 2013 14:27:59 +0100 [thread overview]
Message-ID: <20130124132759.GH12933@pengutronix.de> (raw)
In-Reply-To: <20121107114437.0a563c7e@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Wed, Nov 07, 2012 at 11:44:37AM +0100, Jean Delvare wrote:
> On Wed, 07 Nov 2012 15:58:26 +0530, Naveen Krishna Chatradhi wrote:
> > Don't unmark the device as suspended until after it's been re-setup.
> >
> > The main race would be w.r.t. an i2c driver that gets resumed at the same
> > time (asyncronously), that is allowed to do a transfer since suspended
> > is set to 0 before reinit, but really should have seen the -EIO return
> > instead.
>
> I thought that the suspend order was children first and the resume
> order was parent first?
Same here, why does it not work this way?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: samsung: resume race fix
Date: Thu, 24 Jan 2013 14:27:59 +0100 [thread overview]
Message-ID: <20130124132759.GH12933@pengutronix.de> (raw)
In-Reply-To: <20121107114437.0a563c7e@endymion.delvare>
On Wed, Nov 07, 2012 at 11:44:37AM +0100, Jean Delvare wrote:
> On Wed, 07 Nov 2012 15:58:26 +0530, Naveen Krishna Chatradhi wrote:
> > Don't unmark the device as suspended until after it's been re-setup.
> >
> > The main race would be w.r.t. an i2c driver that gets resumed at the same
> > time (asyncronously), that is allowed to do a transfer since suspended
> > is set to 0 before reinit, but really should have seen the -EIO return
> > instead.
>
> I thought that the suspend order was children first and the resume
> order was parent first?
Same here, why does it not work this way?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130124/818565c5/attachment-0001.sig>
next prev parent reply other threads:[~2013-01-24 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 10:28 [PATCH] i2c: samsung: resume race fix Naveen Krishna Chatradhi
2012-11-07 10:28 ` Naveen Krishna Chatradhi
[not found] ` <1352284106-24988-1-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-11-07 10:44 ` Jean Delvare
2012-11-07 10:44 ` Jean Delvare
[not found] ` <20121107114437.0a563c7e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-01-07 12:05 ` Naveen Krishna Ch
2013-01-07 12:05 ` Naveen Krishna Ch
[not found] ` <CAHfPSqCQ9e3VR3En+hQGWVOt0RRGsmHzHTFvBF+h2-rEX5oXhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-07 12:25 ` Jean Delvare
2013-01-07 12:25 ` Jean Delvare
2013-01-24 13:27 ` Wolfram Sang [this message]
2013-01-24 13:27 ` Wolfram Sang
2013-01-24 16:41 ` Olof Johansson
2013-01-24 16:41 ` Olof Johansson
[not found] ` <CALiw-2F7tG9ogDHj4Yf47T47rBn6mAiH2XvK8jpWB1a3OhNJBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-24 16:44 ` Wolfram Sang
2013-01-24 16:44 ` Wolfram Sang
[not found] ` <20130124132759.GH12933-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-24 16:42 ` Olof Johansson
2013-01-24 16:42 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124132759.GH12933@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=ben-linux@fluff.org \
--cc=ch.naveen@samsung.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=olofj@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.