From: Kent Overstreet <koverstreet@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Valdis.Kletnieks@vt.edu, Hillf Danton <dhillf@gmail.com>,
Benjamin LaHaise <bcrl@kvack.org>,
linux-kernel@vger.kernel.org, linux-aio@kvack.org, zab@zabbo.net,
linux-fsdevel@vger.kernel.org
Subject: Re: next-20130117 - kernel BUG with aio
Date: Thu, 24 Jan 2013 13:39:58 -0800 [thread overview]
Message-ID: <20130124213958.GJ26407@google.com> (raw)
In-Reply-To: <20130124132759.c892fb4c.akpm@linux-foundation.org>
On Thu, Jan 24, 2013 at 01:27:59PM -0800, Andrew Morton wrote:
> On Thu, 24 Jan 2013 13:18:50 -0800
> Kent Overstreet <koverstreet@google.com> wrote:
>
> > So, Andrew - that "smoosh struct kiocb" patch should just be dropped,
> > even if I fixed that issue clearly the idea is a lot less safe than I
> > thought. I've got patches for the other stuff I'm going to mail out
> > momentarily.
>
> Dropped. Do you expect that this will fix everything?
No, I didn't see that bug until after I'd fixed the other three, but as
far as I can tell everything's fixed with the patches I'm about to mail
out - my test VM has been running for the past two days without errors,
it's kill -9'ing a process that's got iocbs in flight to a loopback
device every two seconds.
> Please cc linux-fsdevel on the aio stuff - I'm seeing some AIO things
> over there which aren't cc'ed to lkml or linux-aio.
Will do
> Please also take a look at Jan's recent
> http://www.spinics.net/lists/linux-fsdevel/msg61738.html and have a
> think about how this plays with your patchset.
Oh fun, I've chased a bug or two in that ext4 code, that stuff's
scary... I'm sure it'll take me a bit to wrap my head around what's
going on there but I'm looking at it now.
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
WARNING: multiple messages have this Message-ID (diff)
From: Kent Overstreet <koverstreet@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Valdis.Kletnieks@vt.edu, Hillf Danton <dhillf@gmail.com>,
Benjamin LaHaise <bcrl@kvack.org>,
linux-kernel@vger.kernel.org, linux-aio@kvack.org, zab@zabbo.net,
linux-fsdevel@vger.kernel.org
Subject: Re: next-20130117 - kernel BUG with aio
Date: Thu, 24 Jan 2013 13:39:58 -0800 [thread overview]
Message-ID: <20130124213958.GJ26407@google.com> (raw)
In-Reply-To: <20130124132759.c892fb4c.akpm@linux-foundation.org>
On Thu, Jan 24, 2013 at 01:27:59PM -0800, Andrew Morton wrote:
> On Thu, 24 Jan 2013 13:18:50 -0800
> Kent Overstreet <koverstreet@google.com> wrote:
>
> > So, Andrew - that "smoosh struct kiocb" patch should just be dropped,
> > even if I fixed that issue clearly the idea is a lot less safe than I
> > thought. I've got patches for the other stuff I'm going to mail out
> > momentarily.
>
> Dropped. Do you expect that this will fix everything?
No, I didn't see that bug until after I'd fixed the other three, but as
far as I can tell everything's fixed with the patches I'm about to mail
out - my test VM has been running for the past two days without errors,
it's kill -9'ing a process that's got iocbs in flight to a loopback
device every two seconds.
> Please cc linux-fsdevel on the aio stuff - I'm seeing some AIO things
> over there which aren't cc'ed to lkml or linux-aio.
Will do
> Please also take a look at Jan's recent
> http://www.spinics.net/lists/linux-fsdevel/msg61738.html and have a
> think about how this plays with your patchset.
Oh fun, I've chased a bug or two in that ext4 code, that stuff's
scary... I'm sure it'll take me a bit to wrap my head around what's
going on there but I'm looking at it now.
next prev parent reply other threads:[~2013-01-24 21:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 13:24 next-20130117 - kernel BUG with aio Valdis Kletnieks
2013-01-22 13:43 ` Hillf Danton
2013-01-22 21:28 ` Valdis.Kletnieks
2013-01-23 12:10 ` Hillf Danton
2013-01-24 17:22 ` Valdis.Kletnieks
2013-01-24 21:18 ` Kent Overstreet
2013-01-24 21:27 ` Andrew Morton
2013-01-24 21:27 ` Andrew Morton
2013-01-24 21:39 ` Kent Overstreet [this message]
2013-01-24 21:39 ` Kent Overstreet
2013-01-24 22:25 ` Zach Brown
2013-01-24 22:25 ` Zach Brown
2013-01-24 22:47 ` Jeff Moyer
2013-01-24 22:47 ` Jeff Moyer
2013-01-24 23:03 ` Kent Overstreet
2013-01-24 22:13 ` Kent Overstreet
2013-01-29 13:41 ` Jan Kara
2013-01-29 13:41 ` Jan Kara
2013-01-24 21:43 ` [PATCH 1/3] aio: Fix a null pointer deref in batch_complete_aio Kent Overstreet
2013-01-24 21:43 ` Kent Overstreet
2013-01-25 13:15 ` Hillf Danton
2013-01-25 13:15 ` Hillf Danton
2013-01-24 21:43 ` [PATCH 2/3] aio-kill-ki_retry-fix-fix Kent Overstreet
2013-01-24 21:43 ` Kent Overstreet
2013-01-24 21:43 ` [PATCH 3/3] aio-use-cancellation-list-lazily-fix Kent Overstreet
2013-01-24 21:43 ` Kent Overstreet
2013-01-25 13:30 ` Hillf Danton
2013-01-25 13:30 ` Hillf Danton
2013-01-25 23:12 ` Andrew Morton
2013-01-25 23:12 ` Andrew Morton
2013-01-28 17:37 ` Kent Overstreet
2013-01-28 17:37 ` Kent Overstreet
2013-01-31 21:59 ` next-20130117 - kernel BUG with aio Andrew Morton
2013-02-01 0:37 ` Kent Overstreet
2013-02-05 15:53 ` Valdis.Kletnieks
2013-02-05 17:20 ` Kent Overstreet
2013-02-05 17:48 ` Valdis.Kletnieks
2013-02-06 17:15 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124213958.GJ26407@google.com \
--to=koverstreet@google.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=dhillf@gmail.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.