From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Phillip Susi <psusi@ubuntu.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fslibs: fix llseek on i386
Date: Fri, 25 Jan 2013 10:48:08 +0800 [thread overview]
Message-ID: <20130125024808.GA11093@gmail.com> (raw)
In-Reply-To: <20130125021604.GB28908@thunk.org>
On Thu, Jan 24, 2013 at 09:16:05PM -0500, Theodore Ts'o wrote:
> On Fri, Jan 25, 2013 at 10:25:14AM +0800, Zheng Liu wrote:
> >
> > This patch makes me consider my patches that dump a sparse file in
> > debugfs. In my patch [1] llseek64(2) is called to seek to the next
> > data in target file. So I believe ext2fs_llseek() is a better choice.
> > I am happy to send a newer patch to fix it. What do you think?
> >
> > 1. http://www.spinics.net/lists/linux-ext4/msg36134.html
>
> You're right, we should use ext2fs_llseek() for better portability.
> Thanks,
Yep, the next version will be sent out soon.
Regards,
- Zheng
next prev parent reply other threads:[~2013-01-25 2:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 16:21 [PATCH] e2fslibs: fix llseek on i386 Phillip Susi
2013-01-24 19:51 ` Theodore Ts'o
2013-01-24 20:22 ` Phillip Susi
2013-01-24 20:32 ` Theodore Ts'o
2013-01-25 2:25 ` Zheng Liu
2013-01-25 2:16 ` Theodore Ts'o
2013-01-25 2:48 ` Zheng Liu [this message]
2013-01-25 4:13 ` Theodore Ts'o
2013-01-25 4:14 ` [PATCH] libext2fs: fix ext2fs_llseek " Theodore Ts'o
2013-01-25 4:34 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125024808.GA11093@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=psusi@ubuntu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.