From: Phillip Susi <psusi@ubuntu.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fslibs: fix llseek on i386
Date: Thu, 24 Jan 2013 15:22:37 -0500 [thread overview]
Message-ID: <5101980D.30904@ubuntu.com> (raw)
In-Reply-To: <20130124195158.GC9477@thunk.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 1/24/2013 2:51 PM, Theodore Ts'o wrote:
> How did you find this? I've done a quick search for SEEK_CUR, and
> it looks like only place where this could cause a problem is with
> e2image. And a quick test of a i386 version of e2image with a
> large file system is that it does indeed blow up with an
> "Inappropriate ioctl for device" error.
That's where I found it, but the error should be "seek: Value too
large for defined data type"
> Is there any other potential problems that are caused by this bug?
> I like to explain the impacts of bug fixes in libext2fs for folks
> who are doing bug fix / code archeology.
If e2image is the only internal user of the call with SEEK_CUR, then I
guess it only affects any external users of the library who were doing
this ( I am not aware of any ).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJRAZgNAAoJEJrBOlT6nu752g0IAN4czK0LevEa9Mx2htaZ3oms
TtcpKe7tuXgmvLB0XWv8Q2f6zCDMH7qmWqWZORdx98jg2XeynaEbZvVIQFEsfOVa
05r7sk64TPGXrdkwuqFTe4M7MYmrQmLnfGzd2NMddlWcXOc+R4pFUrrvYbU7QQv/
SGfb9Uo+EFZhSuJLPY1QW4EO09ghD4k6XHnHtioAsgjyxSa4p2NcZiBxmFT7ZJdw
DbET65wHkKT2s+jLQQAOPx/IYAftrZuV7t+YoX7RTS4tdpENlgoVlZ3drCvHB2aG
LwDDns4C1e0cAMncGKh3HY4/CInMZ1jFWHYW+VvuzZNJ7Uxur2mG6NUyWp6cNqU=
=WeEv
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-01-24 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 16:21 [PATCH] e2fslibs: fix llseek on i386 Phillip Susi
2013-01-24 19:51 ` Theodore Ts'o
2013-01-24 20:22 ` Phillip Susi [this message]
2013-01-24 20:32 ` Theodore Ts'o
2013-01-25 2:25 ` Zheng Liu
2013-01-25 2:16 ` Theodore Ts'o
2013-01-25 2:48 ` Zheng Liu
2013-01-25 4:13 ` Theodore Ts'o
2013-01-25 4:14 ` [PATCH] libext2fs: fix ext2fs_llseek " Theodore Ts'o
2013-01-25 4:34 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5101980D.30904@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.