* [PATCH] linux_3.1.bb: Remove bad line continuation.
@ 2013-01-24 13:16 Robert P. J. Day
2013-01-25 17:20 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2013-01-24 13:16 UTC (permalink / raw)
To: meta-ti mailing list
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
guessing just a copy and paste error, which currently generates:
"ERROR: There is a confusing multiline, partially commented expression on line 27 of file
/home/rpjday/oe/dist/layers/meta-ti/recipes-kernel/linux/linux_3.1.bb ().
Please clarify whether this is all a comment or should be parsed."
introduced by commit 9c3a8de11ee9d9d631c2956b845f4c2d32020277
diff --git a/recipes-kernel/linux/linux_3.1.bb b/recipes-kernel/linux/linux_3.1.bb
index 0ec0d26..8a4d847 100644
--- a/recipes-kernel/linux/linux_3.1.bb
+++ b/recipes-kernel/linux/linux_3.1.bb
@@ -23,7 +23,7 @@ SRC_URI += "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;pro
file://defconfig"
# Needs refresh:
-# file://beagle/0003-OMAP3-beagle-HACK-add-in-1GHz-OPP.patch \
+# file://beagle/0003-OMAP3-beagle-HACK-add-in-1GHz-OPP.patch
SRC_URI_append_beagleboard = " file://logo_linux_clut224.ppm \
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] linux_3.1.bb: Remove bad line continuation.
2013-01-24 13:16 [PATCH] linux_3.1.bb: Remove bad line continuation Robert P. J. Day
@ 2013-01-25 17:20 ` Denys Dmytriyenko
2013-01-25 17:26 ` Robert P. J. Day
2013-01-25 17:32 ` Richard Purdie
0 siblings, 2 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2013-01-25 17:20 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: meta-ti mailing list
On Thu, Jan 24, 2013 at 08:16:38AM -0500, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> guessing just a copy and paste error, which currently generates:
No, the recent change in bitbake to handle multiline comments slightly
different, i.e. stricter...
> "ERROR: There is a confusing multiline, partially commented expression on line 27 of file
> /home/rpjday/oe/dist/layers/meta-ti/recipes-kernel/linux/linux_3.1.bb ().
> Please clarify whether this is all a comment or should be parsed."
>
> introduced by commit 9c3a8de11ee9d9d631c2956b845f4c2d32020277
>
> diff --git a/recipes-kernel/linux/linux_3.1.bb b/recipes-kernel/linux/linux_3.1.bb
> index 0ec0d26..8a4d847 100644
> --- a/recipes-kernel/linux/linux_3.1.bb
> +++ b/recipes-kernel/linux/linux_3.1.bb
> @@ -23,7 +23,7 @@ SRC_URI += "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;pro
> file://defconfig"
>
> # Needs refresh:
> -# file://beagle/0003-OMAP3-beagle-HACK-add-in-1GHz-OPP.patch \
> +# file://beagle/0003-OMAP3-beagle-HACK-add-in-1GHz-OPP.patch
>
>
> SRC_URI_append_beagleboard = " file://logo_linux_clut224.ppm \
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux_3.1.bb: Remove bad line continuation.
2013-01-25 17:20 ` Denys Dmytriyenko
@ 2013-01-25 17:26 ` Robert P. J. Day
2013-01-25 17:32 ` Richard Purdie
1 sibling, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2013-01-25 17:26 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti mailing list
On Fri, 25 Jan 2013, Denys Dmytriyenko wrote:
> On Thu, Jan 24, 2013 at 08:16:38AM -0500, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > guessing just a copy and paste error, which currently generates:
>
> No, the recent change in bitbake to handle multiline comments slightly
> different, i.e. stricter...
yes, i saw the earlier contribution from cliff.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux_3.1.bb: Remove bad line continuation.
2013-01-25 17:20 ` Denys Dmytriyenko
2013-01-25 17:26 ` Robert P. J. Day
@ 2013-01-25 17:32 ` Richard Purdie
2013-01-25 17:37 ` Denys Dmytriyenko
1 sibling, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2013-01-25 17:32 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti mailing list
On Fri, 2013-01-25 at 12:20 -0500, Denys Dmytriyenko wrote:
> On Thu, Jan 24, 2013 at 08:16:38AM -0500, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > guessing just a copy and paste error, which currently generates:
>
> No, the recent change in bitbake to handle multiline comments slightly
> different, i.e. stricter...
Previously if you put something in place of that blank line uncommented,
bitbake might have ignored it under certain circumstances. This is
rather unexpected by users.
We therefore made bitbake ask the users to say what they mean :)
Its a bit of a short term pain but a win for usability after that.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux_3.1.bb: Remove bad line continuation.
2013-01-25 17:32 ` Richard Purdie
@ 2013-01-25 17:37 ` Denys Dmytriyenko
2013-01-25 18:52 ` Philip Balister
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2013-01-25 17:37 UTC (permalink / raw)
To: Richard Purdie; +Cc: meta-ti mailing list
On Fri, Jan 25, 2013 at 05:32:13PM +0000, Richard Purdie wrote:
> On Fri, 2013-01-25 at 12:20 -0500, Denys Dmytriyenko wrote:
> > On Thu, Jan 24, 2013 at 08:16:38AM -0500, Robert P. J. Day wrote:
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > >
> > > ---
> > >
> > > guessing just a copy and paste error, which currently generates:
> >
> > No, the recent change in bitbake to handle multiline comments slightly
> > different, i.e. stricter...
>
> Previously if you put something in place of that blank line uncommented,
> bitbake might have ignored it under certain circumstances. This is
> rather unexpected by users.
>
> We therefore made bitbake ask the users to say what they mean :)
>
> Its a bit of a short term pain but a win for usability after that.
Agree. Thanks.
--
Denys
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux_3.1.bb: Remove bad line continuation.
2013-01-25 17:37 ` Denys Dmytriyenko
@ 2013-01-25 18:52 ` Philip Balister
0 siblings, 0 replies; 6+ messages in thread
From: Philip Balister @ 2013-01-25 18:52 UTC (permalink / raw)
To: meta-ti mailing list
On 01/25/2013 12:37 PM, Denys Dmytriyenko wrote:
> On Fri, Jan 25, 2013 at 05:32:13PM +0000, Richard Purdie wrote:
>> On Fri, 2013-01-25 at 12:20 -0500, Denys Dmytriyenko wrote:
>>> On Thu, Jan 24, 2013 at 08:16:38AM -0500, Robert P. J. Day wrote:
>>>>
>>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>>
>>>> ---
>>>>
>>>> guessing just a copy and paste error, which currently generates:
>>>
>>> No, the recent change in bitbake to handle multiline comments slightly
>>> different, i.e. stricter...
>>
>> Previously if you put something in place of that blank line uncommented,
>> bitbake might have ignored it under certain circumstances. This is
>> rather unexpected by users.
>>
>> We therefore made bitbake ask the users to say what they mean :)
>>
>> Its a bit of a short term pain but a win for usability after that.
>
> Agree. Thanks.
>
Think something like this in a bb file:
#FOO = "bar \
inherit something_important
Should the inherit be used or not? That is the question :)
This actually happened to "someone".
Philip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-25 18:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 13:16 [PATCH] linux_3.1.bb: Remove bad line continuation Robert P. J. Day
2013-01-25 17:20 ` Denys Dmytriyenko
2013-01-25 17:26 ` Robert P. J. Day
2013-01-25 17:32 ` Richard Purdie
2013-01-25 17:37 ` Denys Dmytriyenko
2013-01-25 18:52 ` Philip Balister
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.