From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Tony Luck <tony.luck@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Xishi Qiu <qiuxishi@huawei.com>, Jiang Liu <jiang.liu@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: clean up soft_offline_page()
Date: Sun, 27 Jan 2013 02:48:11 +0100 [thread overview]
Message-ID: <20130127014811.GL30577@one.firstfloor.org> (raw)
In-Reply-To: <1359176531-12583-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Sat, Jan 26, 2013 at 12:02:11AM -0500, Naoya Horiguchi wrote:
> Currently soft_offline_page() is hard to maintain because it has many
> return points and goto statements. All of this mess come from get_any_page().
> This function should only get page refcount as the name implies, but it does
> some page isolating actions like SetPageHWPoison() and dequeuing hugepage.
> This patch corrects it and introduces some internal subroutines to make
> soft offlining code more readable and maintainable.
>
> ChangeLog v2:
> - receive returned value from __soft_offline_page and soft_offline_huge_page
> - place __soft_offline_page after soft_offline_page to reduce the diff
> - rebased onto mmotm-2013-01-23-17-04
> - add comment on double checks of PageHWpoison
Ok for me if it passes mce-test
Reviewed-by: Andi Kleen <andi@firstfloor.org>
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Tony Luck <tony.luck@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Xishi Qiu <qiuxishi@huawei.com>, Jiang Liu <jiang.liu@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: clean up soft_offline_page()
Date: Sun, 27 Jan 2013 02:48:11 +0100 [thread overview]
Message-ID: <20130127014811.GL30577@one.firstfloor.org> (raw)
In-Reply-To: <1359176531-12583-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Sat, Jan 26, 2013 at 12:02:11AM -0500, Naoya Horiguchi wrote:
> Currently soft_offline_page() is hard to maintain because it has many
> return points and goto statements. All of this mess come from get_any_page().
> This function should only get page refcount as the name implies, but it does
> some page isolating actions like SetPageHWPoison() and dequeuing hugepage.
> This patch corrects it and introduces some internal subroutines to make
> soft offlining code more readable and maintainable.
>
> ChangeLog v2:
> - receive returned value from __soft_offline_page and soft_offline_huge_page
> - place __soft_offline_page after soft_offline_page to reduce the diff
> - rebased onto mmotm-2013-01-23-17-04
> - add comment on double checks of PageHWpoison
Ok for me if it passes mce-test
Reviewed-by: Andi Kleen <andi@firstfloor.org>
-Andi
next prev parent reply other threads:[~2013-01-27 1:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 5:02 [PATCH v2] mm: clean up soft_offline_page() Naoya Horiguchi
2013-01-26 5:02 ` Naoya Horiguchi
2013-01-27 1:48 ` Andi Kleen [this message]
2013-01-27 1:48 ` Andi Kleen
2013-01-28 18:18 ` [PATCH v3] mm: clean up soft_offline_page() (Re: [PATCH v2] mm: clean up soft_offline_page()) Naoya Horiguchi
2013-01-28 18:18 ` Naoya Horiguchi
2013-01-28 18:28 ` Andi Kleen
2013-01-28 18:28 ` Andi Kleen
2013-01-28 18:32 ` Naoya Horiguchi
2013-01-28 18:32 ` Naoya Horiguchi
2013-01-28 7:25 ` [PATCH v2] mm: clean up soft_offline_page() Xishi Qiu
2013-01-28 7:25 ` Xishi Qiu
2013-01-28 17:05 ` Naoya Horiguchi
2013-01-28 17:05 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127014811.GL30577@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.